Add missing accessibility attributes in the svg icons #20538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
approved these changes
Feb 29, 2020
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
There was a problem hiding this comment.
The change looks good in my tests. @mcsf I'm planning on including this PR as part of the next WordPress RC could you double-check if it is ok to backport the PR?
|
@donmhico thanks! 🎉 @jorgefilipecosta thanks for including this in the WP 5.4 "must have". |
youknowriad
added
[Type] Bug
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20466.
Description
This PR adds
role="img" aria-hidden="true" focusable="false"attributes in all of the available Social Icons in Social Icons Block.Screenshots
Types of changes
Bug fix.
Checklist: