Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow navigation broken in Firefox #2124

Closed
ellatrix opened this issue Aug 1, 2017 · 6 comments
Closed

Arrow navigation broken in Firefox #2124

ellatrix opened this issue Aug 1, 2017 · 6 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

ellatrix commented Aug 1, 2017

To reproduce, create e.g. two paragraphs in Firefox and try to use the arrow keys to move the caret from one to another. Normally this should work. In Firefox it does not. The selection API probably behaves a bit different there, though I'm pretty sure it used to work.

@ellatrix ellatrix self-assigned this Aug 1, 2017
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Aug 1, 2017
@ellatrix
Copy link
Member Author

ellatrix commented Aug 8, 2017

Related: #2222. Also related: pressing arrow twice in empty editable. Looking for an alternative solution that may give a better experience too.

@tg-ephox
Copy link
Contributor

@iseulde are you also looking at #2222? I plan to look at this next if not.
Also @EphoxJames is working on #2392 will this issue overlap with that?

@tg-ephox
Copy link
Contributor

@iseulde part of the problem with this issue is around links. When you left or right arrow through the TinyMCE editor, as it gets to a link the cursor position stays the same when it changes the style to display the link. That causes this code to assume the beginning or end of the block has been reached:

if ( range !== this.lastRange ) {

A different approach to handling this would be required though. Maybe a custom event or a callback prop on the block to say when the end of editor has been reached?

@ellatrix
Copy link
Member Author

@tg-ephox Yeah I know. There's PRs such as #2431.

@ellatrix
Copy link
Member Author

I should have linked to the issues.

@youknowriad
Copy link
Contributor

should be fixed by #2424

ceyhun added a commit that referenced this issue Apr 22, 2020
…ependencies

Update react-native-video dependency to remove Apache 2.0 dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants