Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The @since versions for WP_Block_Parser_Block are inaccurate #22050

Closed
johnbillion opened this issue May 3, 2020 · 0 comments · Fixed by #24819
Closed

The @since versions for WP_Block_Parser_Block are inaccurate #22050

johnbillion opened this issue May 3, 2020 · 0 comments · Fixed by #24819
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Comments

@johnbillion
Copy link
Member

Not a huge problem, but one that affects the accuracy of the inline documentation in WordPress core.

The @since values in packages/block-serialization-default-parser/parser.php (converted to class-wp-block-parser.php in WordPress core) are all set to the version of Gutenberg that they were introduced in, rather than the version of WordPress they were introduced in. It seems they should all be 5.0.0 instead of 3.8.0 when the files get built for WordPress core.
@johnbillion johnbillion added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels May 3, 2020
@oandregal oandregal added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jun 4, 2020
@JustinyAhin JustinyAhin mentioned this issue Aug 26, 2020
Merged
6 tasks
dmsnell pushed a commit that referenced this issue Aug 31, 2020
@JustinyAhin
Correct @SInCE version for block parser package (#24819)
c47ba60 
Fixes #22050

The @SInCE values in packages/block-serialization-default-parser/parser.php (converted to class-wp-block-parser.php in WordPress core) were all set to the version of Gutenberg that they were introduced in, rather than the version of WordPress they were introduced in.

In this patch those version values are properly set to 5.0.0 - the version of WordPress in which they were introduced.

Props: @JustinyAhin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct @since version for block parser package JustinyAhin/gutenberg
2 participants
@johnbillion @oandregal