Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: LinkControl: Remove Popover-associated styling #22437

Closed
Tracked by #35073
aduth opened this issue May 18, 2020 · 2 comments
Closed
Tracked by #35073

Block Editor: LinkControl: Remove Popover-associated styling #22437

aduth opened this issue May 18, 2020 · 2 comments
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 18, 2020

Previously: #18061 (comment)

LinkControl is intended to be used as a standalone form field, much like other *Control input control components. As such, it should make no assumptions about the context in which it is rendered. Currently, there is styling applied to the LinkControl component which assumes that it would be rendered to appear within a popover modal. This should be removed from the underlying component.

Ideally, a generic component like this can "just work" when rendered within a popover. If popover styling is insufficient, it should be considered whether the default popover styling (e.g. padding) is adequate for intended usages. The idea here is: We should avoid the idea that these sorts of components are special and instead aim to have a good set of base styling for popovers which can cover most all usage.

At worst, the styling could be moved to the component which renders the LinkControl within a Popover. As noted at #18061 (comment), there is an option to explore to repurpose the (largely defunct) URLPopover to this end.

@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block editor /packages/block-editor [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) CSS Styling Related to editor and front end styles, CSS-specific issues. labels May 18, 2020
@richtabor
Copy link
Member

@getdave Is this still relevant? Thanks.

@getdave
Copy link
Contributor

getdave commented Jul 13, 2023

I think it can be closed.

@getdave getdave closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants