-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component: LinkControl
tracking issue
#35073
Comments
Great work on this. We should add a dedicated |
Fresh mockups here: #26351 (comment) |
Question: What's holding us from stabilizing this component? It was introduced into the codebase in September 2019 #17557 and whilst it is currently undergoing another design revision that from my perspective has very little to nothing to do with the actual API of the component. Which has changed very little in all these years. I feel strongly that this is a core component that is being used widely throughout the Gutenberg codebase and because it was introduced before the new private API system is also widely used outside of core. I would love for us to recognize that fact and stabilize the LinkControl component sooner rather than later. We can always tweak the underlying tech / the visuals of the component further as we are doing with other stable components. CC: @getdave |
@fabiankaegy Your arguments are sound. Because the work to update the UX of the component is still ongoing from 6.2 -> 6.3 (and on into 6.4 where we hope to wrap up) it didn't seem like a great time to stablise the component. I think @richtabor (who's been working with me on this) would agree that we should be able to wrap up the updates to the component in the 6.4 cycle and thus we could look to stablise for that release. This depends on contributors and where we need to allocate time however, so it might be better thinking of it as "a near future release" as opposed to committing to an specific release. |
Yes, it really should be ironed out and used throughout the experience for 6.4. |
@getdave @richtabor coming back to this, do we now feel like we can finally stabilize this component? Looking at the usage stats there are over 200 plugins in the official Repo already using the component, many of which have a really large user base. Regardless of us continuing to evolve the actual UI of the component I think it is way past time for us to stabilize the API of the component. |
Just tying up loose ends and making sure that the Design / UX refresh for this component is linked here. |
@getdave like I said before, I do not think that stabilizing this component has much to do with us still iterating on the UX & design of the component. The API itself has remained stable for over 3 years now and is getting used in hundreds of plugins in the repository. Therefore I think it is time to stabilize the component now. The work to improve the UI can be an ongoing effort like it is for other components we have. |
@fabiankaegy my comment is purely for update purposes because I realised the Design refresh was not linked here anywhere. Your previous comments still stand. Let's look at landing your stablising PR in 6.5. |
Another year has passed and this is still on the experimental phase. Any plan to move this fordward? |
We should look to stabilise in 6.8 which basically means reviewing and landing #56384 |
The
LinkControl
Component was added via #17557 as an experimental component in September 2019.This Tracking issue is here to keep track of the items that are needed to get the Component out of the
experimental
state.See also the Link UI Overview Issue which tracks currently priorities.
High Priority
LinkControl
Component #56384Medium Priority
TBD
Low Priority
TBD
Issues to organize
Enhancements
label
prop #22438URLInput
to remove requirement for Promise in fetchSuggestions #19526label
prop #22435LinkControl
normal and "Create" suggestions code #20271suggestion
types inLinkControl
#20051url-details
endpoint doesn't look forog:description
when searching for adescription
#33754Standardize required clicks for adding a link #33146Unrelated toLinkControl
.Bugs
__experimentalFetchRichUrlData
function #32725Accessibility
The text was updated successfully, but these errors were encountered: