Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: LinkControl: Migrate suggestions rendering to URLInput #22439

Open
Tracked by #35073
aduth opened this issue May 18, 2020 · 1 comment
Open
Tracked by #35073

Block Editor: LinkControl: Migrate suggestions rendering to URLInput #22439

aduth opened this issue May 18, 2020 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented May 18, 2020

Previously: #18061 (comment)

As discussed in #18061, the new LinkControl component can be considered as a composite component of URLInput, plus labeling behaviors associated with similar *Control input control components. In this model, URLInput should be considered a very barebones component whose sole responsibility should be to render an input field and associated URL autocompletion results from which to pick a value.

Currently, URLInput is enhanced to support "custom" rendering behavior of suggestions, which is leveraged by LinkControl to customize the appearance of its suggestions. These should be migrated to URLInput and considered to be the new default appearance of URL suggestions. The motivation for this is to assure consistency of link suggestions for all use of URLInput (UX), and avoid the maintenance cost associated with maintaining multiple implementations of search result appearances (DevX).
@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block editor /packages/block-editor [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels May 18, 2020
@aduth aduth mentioned this issue May 18, 2020
Closed
@paaljoachim
Copy link
Contributor

paaljoachim commented May 19, 2020 •
edited
Loading

This issue might be associated:
#17293

In regards to: "Make link selection consistent"

@youknowriad youknowriad mentioned this issue Jul 14, 2020
Merged
@adamziel adamziel mentioned this issue Jul 21, 2020
Closed
@fabiankaegy fabiankaegy mentioned this issue Sep 23, 2021
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Block editor /packages/block-editor [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduth @paaljoachim