Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize required clicks for adding a link #33146

Closed
ddegner opened this issue Jul 1, 2021 · 3 comments
Closed

Standardize required clicks for adding a link #33146

ddegner opened this issue Jul 1, 2021 · 3 comments
Labels
[Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@ddegner
Copy link

ddegner commented Jul 1, 2021

What problem does this address?

Adding a link to an image requires an extra click after selecting the page to link to that adding a link to text and other elements doesn't require. This has caused me to think that I added a link but it wasn't actually recorded.

Example of irregularity

What is your proposed solution?

I'd propose that on images after selecting the page to link to that the link is directly saved and the link interface closes, as it does with other elements.

@talldan talldan added [Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement. labels Jul 2, 2021
@richtabor
Copy link
Member

100%. There’s no reason those, or any link UI should be any different.

@getdave
Copy link
Contributor

getdave commented Sep 23, 2021

Just to confirm the link component used on Images is not the <LinkControl>. Rather it uses the underlying <URLInput> component.

Screen Shot 2021-09-23 at 10 25 21

Therefore I'm going to remove this Issue from the <LinkControl> tracking issue.

@richtabor
Copy link
Member

I'm closing this as the LinkControl is coming to other linkable images as detailed in #50893. It'll be nice to have consistent linking everywhere throughout WordPress. 🚀

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants