Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editor.BlockDropZone filter removed #22618

Closed
talldan opened this issue May 26, 2020 · 3 comments
Closed

editor.BlockDropZone filter removed #22618

talldan opened this issue May 26, 2020 · 3 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Regression Related to a regression in the latest release

Comments

@talldan
Copy link
Contributor

talldan commented May 26, 2020

Describe the bug
#19514 converted the old BlockDropZone component to a hook (useBlockDropZone), but seems to have inadvertently removed the editor.BlockDropZone filter at the same time.

To reproduce
Steps to reproduce the behavior:

  1. Try registering a filter for editor.BlockDropZone.
  2. Observe that it is never triggered

Expected behavior
The filter continues to work as before
@talldan talldan added [Type] Bug An existing feature does not function as intended Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Drag and Drop Drag and drop functionality when working with blocks labels May 26, 2020
@talldan talldan mentioned this issue May 26, 2020
Merged
6 tasks
@gziolo gziolo added [Type] Regression Related to a regression in the latest release and removed [Type] Bug An existing feature does not function as intended labels May 26, 2020
@youknowriad
Copy link
Contributor

Seems like the ship has sailed for this one without real impact, I wonder if we should leave it as is.

@talldan
Copy link
Contributor Author

talldan commented May 27, 2020

@youknowriad #22619 removes it from the docs if we want to merge that and close this.

@youknowriad
Copy link
Contributor

yes, i'm fine with that personally.

@talldan talldan closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @talldan @gziolo