-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BlockDropZone react hook and update docs #22619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Developer Documentation
Documentation for developers
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Block editor
/packages/block-editor
labels
May 26, 2020
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block editor
/packages/block-editor
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Developer Documentation
Documentation for developers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#19514 converted the old
BlockDropZone
component to a hook.This PR is a small change that moves the useBlockDropZone hook into a folder of the same name and updates some documentation.
The component is only used internally within the block-editor package, and this PR also updates the one import.
It looks #19514 also removed the
editor.BlockDropZone
filter, which is likely a backwards compatibility issue. I've made a separate issue for that - #22618.How has this been tested?
Types of changes
Non-breaking code quality/documentation change
Checklist: