Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Text component #23941

Closed
jameskoster opened this issue Jul 14, 2020 · 1 comment
Closed

Update Text component #23941

jameskoster opened this issue Jul 14, 2020 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Design System Issues related to the system of combining components according to best practices. [Package] Components /packages/components [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jameskoster
Copy link
Contributor

In order to improve the wordpress.org Figma libraries @noahshrader has attentively created a collection of text styles in Figma that match what has been implemented throughout Gutenberg.

However, the styles defined in the Text component are not in alignment with that broader implementation, and need updating. For example, the Button style in the Text component sets the font-size to 14px, but the actual Buttons in the Gutenberg UI are rendered at 13px.

The Text component is also missing some styles like Helper Text and Section Heading.
@jameskoster jameskoster mentioned this issue Jul 17, 2020
Closed
@talldan talldan added [Package] Components /packages/components [Type] Task Issues or PRs that have been broken down into an individual action to take CSS Styling Related to editor and front end styles, CSS-specific issues. labels Aug 12, 2020
@jameskoster jameskoster added the Design System Issues related to the system of combining components according to best practices. label Sep 24, 2024
@jameskoster
Copy link
Contributor Author

Closing. This is superseded by #64340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Design System Issues related to the system of combining components according to best practices. [Package] Components /packages/components [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update/text component jameskoster/gutenberg
2 participants
@talldan @jameskoster