Update/text component #24020
Closed
Update/text component #24020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23941
I've updated the values for existing styles based on the visual audit @noahshrader recently did. Figma file here for reference.
This involved adding new styles for
helpertext,sectionheading, andlabel.semibold. I didn't add the 'Small Button Text' style because I couldn't see where that was utilised in the UI.I suspect we may need to rename
label.semiboldto something less explicit. Suggestions?