Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light-weight extensions #2460

Closed
jasmussen opened this issue Aug 18, 2017 · 9 comments
Closed

Add light-weight extensions #2460

jasmussen opened this issue Aug 18, 2017 · 9 comments
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts
Milestone

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Aug 18, 2017

This ticket suggests a new type of light-weight editor extensions.

extensions

The ellipsis menu could hold light-weight extensions, such as:

  • spell check
  • share document for proof reading
  • collaboration

... or indeed any other extension that might want to add actions that are global to all content on the page. These extensions would be very light-weight, and would take an action on the page, and then either present a modal with results/further actions, or be done.

Thoughts?


This issue has been edited to focus on just extensions. The rearrangement has happened separately.

@jasmussen jasmussen added General Interface Parts of the UI which don't fall neatly under other labels. Design [Type] Question Questions about the design or development of the editor. labels Aug 18, 2017
@jasmussen
Copy link
Contributor Author

For comparison purposes, this is what the editor bar looks like today:

screen shot 2017-08-18 at 11 44 42

@paaljoachim
Copy link
Contributor

paaljoachim commented Aug 18, 2017

Hey Joen

This looks really nice:
screen shot 2017-08-18 at 21 53 30

The publish button becomes more prominent.
Settings words are removed to only show the icon (a tooltip could show up on hover with the words Settings.) It gives more space in the top right area.
An additional optional menu is added with the dots. It is much used in browsers. It can then also be extended as you showed in your example by plugin/theme authors.
What I am hesitant about is the Post Settings and Block Settings words. It creates repetition.

gutenberg-top-right

I would probably just have the word Post and Block and remove the word Settings.
Something like this:

gutenberg-top-right-adjusted

@afercia
Copy link
Contributor

afercia commented Aug 19, 2017

The Settings toggle moved to the right of the publish button could help if there were no ellipsis button 🙂 . The a11y issue isn't solved yet. Ideally, a toggle that expands something should be immediately followed by the expanded "thing" in the source order. That would require to move the toggle to the last position in the sidebar and move the sidebar before the editor.

Having the toggle and the expandable panel contiguous in the source order feels very natural and intuitive to keyboard and assistive technologies users, as all they need to do is continue navigating content to find the sidebar.

If the toggle and the sidebar are not contiguous, then there's the need to manage focus programmatically from the toggle to the sidebar. Also, when tabbing backwards from the sidebar, I'd expect to find the toggle. Instead, I'm forced to navigate through all the post content to finally land on the toolbar and have the ability to close/open the sidebar.

@jasmussen
Copy link
Contributor Author

Your help is always appreciated, Andrea.

That would require to move the toggle to the last position in the sidebar and move the sidebar before the editor.

If we wanted to have an ellipsis menu for plugins, where would it have to sit in the editor bar in order to not break the above? Would it be enough if it were to the left of the cog, right of the publish button?

@hedgefield
Copy link

Great work @jasmussen!

To the point of the ellipsis menu, it would seem natural to me to put it between preview and publish. After all, it contains extensions that affect what you are doing within the post or page you are editing. It extends the options already visible in the toolbar with more things you can do before publishing. Does that make sense?

The concept of a menu like that is great, it offers another hook for developers to put stuff into , without cluttering the toolbar more. 👌

@aduth aduth added the [Feature] Extensibility The ability to extend blocks or the editing experience label Sep 1, 2017
@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed [Type] Question Questions about the design or development of the editor. labels Sep 24, 2017
@karmatosed karmatosed added this to the Beta, Needs to happen milestone Sep 24, 2017
@karmatosed
Copy link
Member

I would love to see this implemented. I think we can reach a middle ground with the ellipsis menu, what do you think @afercia?

@afercia
Copy link
Contributor

afercia commented Sep 25, 2017

@karmatosed the a11y issue here is not solved yet. Considerations from my previous comment still stand.

@jasmussen jasmussen changed the title Rearrange toolbar slightly, and add light-weight extensions Add light-weight extensions Oct 16, 2017
@karmatosed
Copy link
Member

Something to add into this would be a true distraction-free mode like this:

1

I would like to work on a plugin for this, not sure about it being core. I also think as oppose to #2876 this is a true distraction free mode, enabled by this interaction.

@mtias
Copy link
Member

mtias commented Nov 20, 2017

Closing in favor of #3330 which has more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

No branches or pull requests

7 participants