Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended settings visible when settings are hidden #2849

Closed
ellatrix opened this issue Oct 2, 2017 · 13 comments · Fixed by #3065
Closed

Extended settings visible when settings are hidden #2849

ellatrix opened this issue Oct 2, 2017 · 13 comments · Fixed by #3065
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@ellatrix
Copy link
Member

ellatrix commented Oct 2, 2017

When the normal settings are hidden, extended settings remain visible.

@ellatrix ellatrix added Design Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended labels Oct 2, 2017
@ellatrix ellatrix changed the title Extended setting visible when settings are hidden Extended settings visible when settings are hidden Oct 3, 2017
@DevinWalker
Copy link
Contributor

I'm attempting to contribute and resolve this issue but with a lack of screenshot or further description it's difficult for me to understand the exact problem needing to be resolved.

@DevinWalker
Copy link
Contributor

After further examination, I see the issue that is described in this issue.

@gziolo
Copy link
Member

gziolo commented Oct 11, 2017

@iseulde or @DevinWalker can you provide a screenshot? It will help reviewing the fix :)

@youknowriad
Copy link
Contributor

When the normal settings are hidden, extended settings remain visible.

Do we really need those two panels to be tied together. My personal opinion would be no but curious why do you think they should be?

@ellatrix
Copy link
Member Author

I don't think the have to be tied together, but on the other hand, I also don't want to see extended settings when I hide "normal" settings... I would hid normal settings to have a clear screen for writing, but then there's still this box on the bottom of the screen in my way.

@aduth
Copy link
Member

aduth commented Oct 12, 2017

I'm inclined to agree with @youknowriad that these are two separate panels and closing one shouldn't necessarily close the other.

@ellatrix
Copy link
Member Author

Okay, what the best way to hide this panel then? @jasmussen Any ideas? 😊

@DevinWalker
Copy link
Contributor

DevinWalker commented Oct 12, 2017

Option 1: Toggle with Settings cog icon

My first preference would be to have the Extended Settings tied to the normal settings' show/hide button:

2017-10-12_14-26-49

This only requires two clicks to access the panel.

Option 2: Add another toggle to settings panel

Another option would be to have another toggle within the settings panel like so:

2017-10-12_14-26-49

However, this is harder to find and would require two clicks to access the panel and maybe even three clicks if the panel is not toggled open when displayed.

Option 3: Add toggle option under top menu toggle

Yet another option would be to add another item to the top menu toggle to display extended settings:

2017-10-12_14-34-23

This display place seems OK to me but would again require more clicks. Personally I think the "Extended Settings" can contain a lot of important information to admins so displaying it alongside the normal settings seems the best option.

@jasmussen
Copy link
Contributor

jasmussen commented Oct 13, 2017

I like @DevinWalker's 1st mockup. That is, the one that toggles off the Extended Settings panel when the sidebar is also off. (Note, I edited this as I realized I was previously referring to another mockup, which was mistaken.)

I know the metabox project is ongoing, but the side drawer and the bottom drawer are all in the same category of settings, and so they should both be toggled by the same. This seems at the very least worth trying, so we can decide if we dig this. If we don't, there are many other things we can explore.

Additionally, if there are no metaboxes in the Extended Settings drawer, we should probably not show that panel at all.

@hedgefield
Copy link

To clarify, that's the one with the text below the metaboxes in the sidebar?

This issue gets to something I also explored with a distraction-free toggle that hides all the toolbars at once (#2876). We already have a toggle for the sidebar and one for the menu, adding a third step to clear the clutter seems like overkill. At the very least including the extended settings in the settings toggle seems like the best idea.

@jasmussen
Copy link
Contributor

To clarify, that's the one with the text below the metaboxes in the sidebar?

No, it's this panel at the bottom:

screen shot 2017-10-18 at 13 25 54

Re: distraction free, I personally feel like the ability to toggle off the sidebar, and collapse the navigation menu on the left, counts as the most discoverable type of distraction-free feature. Mostly, though, I feel like if an interface needs a distraction-free toggle (that's labelled as such), it indicates more fundamental problems with the interface. That goes for Gutenberg too, so I'd rather we fix those issues that makes us want a distraction free toggle ;)

However Tammie recently posted a new idea here: #2460 (comment) — that is, making a distraction free extension that goes further.

@hedgefield
Copy link

@jasmussen ah you changed your reply, it said option 2 but I see (and expected) you meant option 1, then we are in agreement :)

@jasmussen
Copy link
Contributor

Haha I do apologize, I must've been tired when I wrote the previous version.

Glad to hear agreement. I think I can pr this one pretty quick

jasmussen pushed a commit that referenced this issue Oct 19, 2017
This fixes #2849, props @DevinWalker for concept.

Extended settings is the panel at the bottom that holds extra metaboxes. It is present when a plugin adds such metaboxes, otherwise it's not there. Given that the purpose of being able to dismiss the sidebar is for a simpler, lighter, writing experience, it makes sense to hide this panel if the sidebar panel is hidden. This PR does that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
7 participants