Remove deprecated __unstableMigrate function

[senadir]

wp.data.plugins.persistence has a deprecated function __unstableMigrate that should have been removed when WP 5.4 was released.

gutenberg/packages/data/src/plugins/persistence/index.js

Lines 225 to 294 in 655475a

	/**
	* Deprecated: Remove this function and the code in WordPress Core that calls
	* it once WordPress 5.4 is released.
	*/
	persistencePlugin.__unstableMigrate = ( pluginOptions ) => {
	const persistence = createPersistenceInterface( pluginOptions );
	const state = persistence.get();
	// Migrate 'insertUsage' from 'core/editor' to 'core/block-editor'
	const insertUsage = get( state, [
	'core/editor',
	'preferences',
	'insertUsage',
	] );
	if ( insertUsage ) {
	persistence.set( 'core/block-editor', {
	preferences: {
	insertUsage,
	},
	} );
	}
	let editPostState = state[ 'core/edit-post' ];
	// Default `fullscreenMode` to `false` if any persisted state had existed
	// and the user hadn't made an explicit choice about fullscreen mode. This
	// is needed since `fullscreenMode` previously did not have a default value
	// and was implicitly false by its absence. It is now `true` by default, but
	// this change is not intended to affect upgrades from earlier versions.
	const hadPersistedState = Object.keys( state ).length > 0;
	const hadFullscreenModePreference = has( state, [
	'core/edit-post',
	'preferences',
	'features',
	'fullscreenMode',
	] );
	if ( hadPersistedState && ! hadFullscreenModePreference ) {
	editPostState = merge( {}, editPostState, {
	preferences: { features: { fullscreenMode: false } },
	} );
	}
	// Migrate 'areTipsEnabled' from 'core/nux' to 'showWelcomeGuide' in 'core/edit-post'
	const areTipsEnabled = get( state, [
	'core/nux',
	'preferences',
	'areTipsEnabled',
	] );
	const hasWelcomeGuide = has( state, [
	'core/edit-post',
	'preferences',
	'features',
	'welcomeGuide',
	] );
	if ( areTipsEnabled !== undefined && ! hasWelcomeGuide ) {
	editPostState = merge( {}, editPostState, {
	preferences: {
	features: {
	welcomeGuide: areTipsEnabled,
	},
	},
	} );
	}
	if ( editPostState !== state[ 'core/edit-post' ] ) {
	persistence.set( 'core/edit-post', editPostState );
	}
	};

[sbappan]

Hi. Can I work on this issue?

[senadir]

@sbappan absolutely! I assigned this to you.

[sbappan]

@sbappan absolutely! I assigned this to you.

Thank you!

[BertAnthonyRochester]

#24931 (comment)

[skorasaurus]

Per discussion in the PR, #25023 ; waiting until the plugin requires 5.6.

[skorasaurus]

no longer blocked due to #34536 ; 5.7 is the minimum version now

[t-hamano]

As this issue has been properly handled by #39795, so we closed the related PR #25023.
Therefore, we would like to close this issue as well 👍