Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Rename LeftSidebar #25616

Closed
david-szabo97 opened this issue Sep 24, 2020 · 2 comments · Fixed by #26517
Closed

Site Editor: Rename LeftSidebar #25616

david-szabo97 opened this issue Sep 24, 2020 · 2 comments · Fixed by #26517
Assignees
@mattwiebe
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@david-szabo97
Copy link
Member

Discussion: #25506 (comment)

We should rename the LeftSidebar component to something generic. Left and right can be confusing, when the page is viewed in a RTL language, then the left sidebar will be on the right side.

Since we have another Sidebar component in edit-site, we need to come up with something else.
@mtias
Copy link
Member

mtias commented Sep 25, 2020

We should definitely move away from any visual location name. For the W menu I think we should call it SiteNavigation or MainMenu

@mtias mtias mentioned this issue Sep 25, 2020
Closed
8 tasks
@mtias mtias added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Oct 1, 2020
@mattwiebe
Copy link
Contributor

We should definitely move away from any visual location name. For the W menu I think we should call it SiteNavigation or MainMenu

It's currently NavigationSidebar, what's currently LeftSidebar actually contains the Block Library, so I think I'll just call it BlockLibrary. I'd tend to leaving NavigationSidebar as-is.

@mattwiebe mattwiebe mentioned this issue Oct 27, 2020
Merged
6 tasks
@mattwiebe mattwiebe self-assigned this Oct 27, 2020
mattwiebe added a commit to mattwiebe/gutenberg that referenced this issue Nov 6, 2020
@mattwiebe
Rename "Left Sidebar" to "Secondary Sidebar" in the interface
641f7b1 
Finding the balance between too general and too specific is tricky.

Fixes WordPress#25616
gziolo pushed a commit that referenced this issue Nov 9, 2020
@mattwiebe
Rename "Left Sidebar" to "Secondary Sidebar" in the interface (#26517)
86e5cc1 
Finding the balance between too general and too specific is tricky.

Fixes #25616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwiebe mattwiebe

Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor: Rename left sidebar → block library mattwiebe/gutenberg
3 participants
@mattwiebe @mtias @david-szabo97