Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeakerDeck (generic embed) caption looks different from other embed captions on front of site #2580

Closed
2 tasks
wpfangirl opened this issue Aug 28, 2017 · 3 comments
Labels
[Status] Needs More Info Follow-up required in order to be actionable.

Comments

@wpfangirl
Copy link

Issue Overview

I embedded a slideshow from SpeakerDeck easily using the generic Embed block (since there is no SpeakerDeck block [yet]). Within the editor, the caption looks like other captions. On the front of the site, the caption looks like the caption in the editor, and not like the other captions, which are indistinguishable visually from paragraph text. I suspect this is actually more a lack in the theme style for Gutenberg caption display than a bug in the generic embed display, but the captions should all be consistent.

Steps to Reproduce (for bugs)

https://gutenberg.eastbaywp.com/post-with-all-the-blocks

Chrome for Windows, Gutenberg 0.90

Expected Behavior

Captions should be consistent across embed/block types.

Current Behavior

speakerdeck embed caption displays differently on front of site
speakerdeck embed in gutenberg editor

Possible Solution

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@karmatosed
Copy link
Member

This is interesting, I probably am missing a step :) When I try and reproduce I get this:

2017-08-30 at 19 51

I was using the embed block and the link you gave above. Could you please maybe provide some steps as I would love to recreate.

@karmatosed karmatosed added the [Status] Needs More Info Follow-up required in order to be actionable. label Aug 30, 2017
@karmatosed
Copy link
Member

As I can't recreate, lets close this for now. We can always reopen if we have more information.

@wpfangirl
Copy link
Author

wpfangirl commented Sep 24, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

2 participants