Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Nav Components do not match updated design #26336

Closed
joelclimbsthings opened this issue Oct 20, 2020 · 0 comments · Fixed by #26338
Closed

Experimental Nav Components do not match updated design #26336

joelclimbsthings opened this issue Oct 20, 2020 · 0 comments · Fixed by #26338
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Type] Enhancement A suggestion for improvement.

Comments

@joelclimbsthings
Copy link
Contributor

Describe the bug
The design for the navigation component has been updated to require a few minor CSS updates; including:

  • The individual items should have a height of 32px
  • Consecutive groups should have a 24px spacing
  • Cancelling native margin styles present in wp-admin environment

To reproduce
Steps to reproduce the behavior:

  1. Run storybook:dev
  2. Click navigation component
  3. Notice that it does not match screenshots

Expected behavior
Should match screenshots

Screenshots
Item Height:
Screenshot from 2020-10-20 14-33-16

Group spacing:
Screenshot from 2020-10-20 14-26-56

joelclimbsthings added a commit to joelclimbsthings/gutenberg that referenced this issue Oct 20, 2020
… individual items (WordPress#26336)

The designs have been updated, along with a few revisions that need to be added from wc-admin.
@talldan talldan added [Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Type] Enhancement A suggestion for improvement. labels Oct 22, 2020
psealock pushed a commit that referenced this issue Oct 27, 2020
* Adding spacing between navigation group components, fixing height for individual items (#26336)

The designs have been updated, along with a few revisions that need to be added from wc-admin.

* Adding simple Story for navigation component to illustrate <NavigationGroup />

* Changing font-size for navigation items to 13px as per design

* Switching height on navigation item element to a height: auto with min-height to account for long labels.

* Applying prettier formatting to style merged in github.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation Component A navigational waterfall component for hierarchy of items. [Type] Enhancement A suggestion for improvement.
Projects
None yet
2 participants