Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post comments form placeholder state #26999

Closed
karmatosed opened this issue Nov 16, 2020 · 6 comments · Fixed by #40368
Closed

Post comments form placeholder state #26999

karmatosed opened this issue Nov 16, 2020 · 6 comments · Fixed by #40368
Labels
[Block] Post Comments Form Affects the Comments Form Block Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

karmatosed commented Nov 16, 2020

The current placeholder for post comments is a little lacking:

image

Problem

This block doesn't require any interactions and the output is on the front of the site. As a result, this is what shows.

Solution

My suggestion is to show what will be output, however I understand this could feel editable as a result. In #26865 I have been exploring styling here and potentially that could be used here. Rather than having the white placeholder background that leads to interaction, perhaps a simple border and showing content works?

2

My own suggestion would be to consider not even having the border, but I'm open to feedback there.

2

Feedback

It would be great to get feedback on this. Is there a default way of treating blocks like this for placeholders that could be used for this one perhaps?

@jameskoster
Copy link
Contributor

+1 to just displaying the form. Related: #26856

@karmatosed
Copy link
Member Author

Ah great, @jameskoster do you think this one should be closed to focus on that issue? Happy to do that if that one is scooping them all up.

@jameskoster
Copy link
Contributor

No I think we can leave this open. I suspect that #26856 may be split up any way.

@karmatosed
Copy link
Member Author

Looks like the feedback here is to display the form, so goign to move this to needs dev with that recommendation and to also not show a border.

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Nov 19, 2020
@ockham
Copy link
Contributor

ockham commented Apr 14, 2022

We're going to try to implement a basic placeholder state as mocked up here for WP 6.0 (since we need it for #40256, among other things). See this comment for background.

@ockham ockham added this to the WordPress 6.0 milestone Apr 14, 2022
@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 14, 2022

Updating the current reply comment box. I made a user named user.
From the Twenty Twenty Two theme.

Logged in user:

Screenshot 2022-04-14 at 22 10 47

Not logged in user:

Screenshot 2022-04-14 at 22 11 40

We could perhaps do something like this (simplifying even further):

-- As a version 1 iteration.
Leave-a-Reply-comment-box


Fully modifying the Post Comments block with inner blocks it contains.

-- As a version 2 iteration.

Circling back to the not logged in user information. So that we can customize the various fields of the Post Comments block.

"Leave a Reply" text. --> We might want to change/remove the heading to another text or another heading type.
Your email address will not be published. Required fields are marked * ---> We might want to change/remove this text.
Comment * ----> We might want to change Comment text and * to something else.
Name ---> Change text.
Email ---> Change text.
Website ---> Change text, or remove.
-checkbox- Save my name, email, and website in this browser for the next time I comment. ---> Change text or remove.

This means we will need to use the full not logged in user information as a parent block with inner blocks that can be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants