-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post comments form placeholder state #26999
Comments
+1 to just displaying the form. Related: #26856 |
Ah great, @jameskoster do you think this one should be closed to focus on that issue? Happy to do that if that one is scooping them all up. |
No I think we can leave this open. I suspect that #26856 may be split up any way. |
Looks like the feedback here is to display the form, so goign to move this to needs dev with that recommendation and to also not show a border. |
We're going to try to implement a basic placeholder state as mocked up here for WP 6.0 (since we need it for #40256, among other things). See this comment for background. |
Updating the current reply comment box. I made a user named user. Logged in user:Not logged in user:We could perhaps do something like this (simplifying even further):Fully modifying the Post Comments block with inner blocks it contains.-- As a version 2 iteration. Circling back to the not logged in user information. So that we can customize the various fields of the Post Comments block. "Leave a Reply" text. --> We might want to change/remove the heading to another text or another heading type. This means we will need to use the full not logged in user information as a parent block with inner blocks that can be modified. |
The current placeholder for post comments is a little lacking:
Problem
This block doesn't require any interactions and the output is on the front of the site. As a result, this is what shows.
Solution
My suggestion is to show what will be output, however I understand this could feel editable as a result. In #26865 I have been exploring styling here and potentially that could be used here. Rather than having the white placeholder background that leads to interaction, perhaps a simple border and showing content works?
My own suggestion would be to consider not even having the border, but I'm open to feedback there.
Feedback
It would be great to get feedback on this. Is there a default way of treating blocks like this for placeholders that could be used for this one perhaps?
The text was updated successfully, but these errors were encountered: