Comments Query Loop: Add Post Comments Form block to Comments Query Loop template #40256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
the
[Block] Comments
SantosGuillamot
requested review from
paaljoachim,
ockham,
cbravobernal and
DAreRodz
|
Size Change: +8 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
WP 5.9.3. I removed the Post Comments block and added in the Comments Query Loop block. This is what I see: Backend
Frontend
Looks good! Btw. |
paaljoachim
approved these changes
Apr 12, 2022
|
The question comes up should this be backported to WP 6.0? |
|
Noting that Post Comment block is still marked as experimental in the Gutenberg plugin: gutenberg/packages/block-library/src/index.js Lines 265 to 276 in 415e404 |
|
@paaljoachim post-comments-form is an experimental block, it would have to be stabilized for this change to be backported. |
|
I found some differences between the behavior of this block vs the form that is being rendered on the Post Comments block function. Also, there is a "bug" in Core that, if we have the Core I will create an issue. |
|
Could you link the issue here @c4rl0sbr4v0 ? 🙂 |
I think Carlos didn't end up filing one after we decided that we'll include most relevant information in #40268. (I think that most of these issues will now be fixed by the latest state of #40268, plus maybe some additional styling of the Post Comments Form block.) |
|
Thank you @ockham ! :) Yup, I saw this now - I was just looking for more context when I first saw this PR! |
@priethor, @annezazu - what do you think? I have never tried using the Post Comment Form block so I can’t tell without testing. Is there any demo presenting the block? |
|
@gziolo One thing I'm aware of is that the block is currently displaying the following in the editor:
I.e. we'll need to implement a placeholder that visually represents better what it looks like on the frontend. |
ockham
added
the
[Status] Blocked
ockham
requested changes
Apr 14, 2022
There was a problem hiding this comment.
Note that this PR is blocked since the Post Comments Form is still marked as experimental.
See the comments on the PR for further discussion.
FWIW, there's an old issue with some mockups for the Post Comments Form. I forgot to say: We're not going to try to implement a full-fledged, editable, Comments Form Template block (as described in #24221) for now; that would be way beyond scope for WP 6.0. |
|
Without the comments form block or the post comments block, there is no way to add a comment when a block theme is active. Personally, I would prefer if the basic, no template comments form was made stable because I am concerned that the alternative is to revert the addition of the new comment query blocks and revert the deprecation of the post comments block. (The |
|
Thanks @carolinan! I agree with your reasoning 😄 We've started work required for stabilizing the Post Comments Form block. |
This was referenced Apr 19, 2022
ockham
approved these changes
Apr 22, 2022
gziolo
removed
the
[Status] Blocked
ndiego
added
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
Apr 25, 2022
|
Cherry-picked to |
gziolo
removed
the
Backport to WP 6.7 Beta/RC
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add the Post Comments Form block to the Comments Query Loop template to ensure it appears directly after inserting the comments in the editor.
Fixes #40225
Why?
It's reasonable to assume that, when users add the Comments Loop, they will want to use the Post Comments Form as well. They could always delete it if it isn't needed.
How?
Just adding the Post Comments Form block to the template.
Testing Instructions
In trunk:
In the PR branch: