Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo Block: Add the same dimensions settings as the Image block #29217

Closed
Copons opened this issue Feb 22, 2021 · 1 comment · Fixed by #31607
Closed

Site Logo Block: Add the same dimensions settings as the Image block #29217

Copons opened this issue Feb 22, 2021 · 1 comment · Fixed by #31607
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Bug An existing feature does not function as intended

Comments

@Copons
Copy link
Contributor

Copons commented Feb 22, 2021

Description

The Site Logo block only has a "Image width" setting which not only can malfunction, it's also different than the dimensions settings of the Image block.

Since both blocks are used to render an image, they should have the same settings available.
For example, the Site Logo block should probably use the same ImageSizeControl component to handle its dimensions as the Image block.

Step-by-step reproduction instructions

  1. Insert a Site Logo block (add an image if needed), followed by a Paragraph block.
  2. Resize the logo using the resize handlers around the image itself.
  3. Then, try resizing the logo using the slider in the block settings sidebar.

Expected behaviour

The Site Logo wrapper resized along with the image.

Actual behaviour

The Site Logo wrapper didn't resize appropriately, and the image was either overlapping the following block, or smaller than the wrapper.

Screenshots or screen recording (optional)

Original Resize to Small Resize to Large
Screenshot 2021-02-22 at 12 11 41 Screenshot 2021-02-22 at 12 11 17 Screenshot 2021-02-22 at 12 11 27

WordPress information

  • WordPress version: 5.7-beta2-50343
  • Gutenberg version: 10.0.0-rc.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Desktop
  • Operating system: macOS 11.2.1
  • Browser: Chrome 88.0
@Copons Copons added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block and removed [Type] Enhancement A suggestion for improvement. labels Feb 22, 2021
@annezazu
Copy link
Contributor

annezazu commented Mar 1, 2021

This seems similar to this issue with the general Image block: #12168

In terms of resizing, the current experience with the site logo is pretty bizarre using the Site Logo Settings so it would be great to create some consistency here across the two blocks in terms of how adjustments are made:

site.logo.mov

User feedback as part of the second FSE Outreach Program's call for testing underscores this sentiment:

Yes, I was trying to size the logo I added using the what appeared to be resize handles. but it did nothing I expected. Eventually I found that the block had settings in the right panel, but I had to look quite hard for this.

Edited to add in the above quote

@jasmussen jasmussen mentioned this issue May 10, 2021
7 tasks
ajlende added a commit to ajlende/gutenberg that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants