Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template part flow: Add "Area" selection input to modal. #29222

Closed
jameskoster opened this issue Feb 22, 2021 · 7 comments · Fixed by #30395
Closed

Create template part flow: Add "Area" selection input to modal. #29222

jameskoster opened this issue Feb 22, 2021 · 7 comments · Fixed by #30395
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

When manually creating a template part from a selection of blocks, the following modal appears:

Along with the template part name, we should also provide an affordance to specify the template part area (Header, Footer, etc).

We might use the dedicated icons for template parts in a segmented control arrangement to achieve this.

@jameskoster jameskoster added Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 22, 2021
@aristath
Copy link
Member

Should we also add aside? (not sidebar)

@jameskoster
Copy link
Contributor Author

I think the input here should expose all areas. So if aside exists, it would appear as an option. I wonder if that's better left to the HTML element option though? 🤔

@jameskoster jameskoster added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Feb 24, 2021
@jameskoster
Copy link
Contributor Author

Blocked by #29295

@jameskoster
Copy link
Contributor Author

Removing the "Needs design" label since the "design" for this should be entirely informed by #29295.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Mar 2, 2021
@jameskoster
Copy link
Contributor Author

On second thoughts, perhaps there is a case to be made for a more elaborate design here, since it may be the first time a user encounters the "area" concept.

Create template part

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Mar 5, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 30, 2021
@paaljoachim
Copy link
Contributor

I like the latest design.
Clicking to "Create Template Part"
Shows Name and "category" for the part.
Such as Header, Footer and General. Perhaps Sidebar should be added as well.
So it becomes Header, Sidebar, Footer and General.

Thinking broader. A similar method can be used when creating a Pattern. User selects a name and the category the Pattern should be in.

@Addison-Stavlo
Copy link
Contributor

Perhaps Sidebar should be added as well.

Once we are ready to support the 'sidebar' area it should definitely be part of the list. Once we support a larger amount of options, perhaps that 'area' selection should have a max-height and scroll? 🤔

@priethor priethor removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants