Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template part: Area selection UI #29295

Open
jameskoster opened this issue Feb 24, 2021 · 15 comments
Open

Template part: Area selection UI #29295

jameskoster opened this issue Feb 24, 2021 · 15 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

When #29159 is merged it will be possible to update the area of the selected Template Part:

Screenshot 2021-02-24 at 10 39 02

Since we have dedicated icons for these areas that will be surfaced to users in the Toolbar, List View, and the Inspector, it may be worth exploring designs that incorporate them into this selection flow in order to establish holistic continuity in the UI.

One option might be to use a segmented control instead of a dropdown:

Another option would be to stick with the select but enrich the dropdown:

Screenshot 2021-02-24 at 11 04 13

Whichever solution we go with, we should be aware that this element will likely exist in other environments, e.g. #29222.

@jameskoster jameskoster added Needs Design Needs design efforts. [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 24, 2021
@mtias
Copy link
Member

mtias commented Feb 24, 2021

That last one seem like a lot. I can see it being useful when creating a new one from scratch, but to reassign it seems it should be simpler and assume context already (it's in "advanced" in the end).

@jameskoster
Copy link
Contributor Author

I don't have strong feelings either way. I suppose the main thing to decide upon is whether we need to display the descriptions here.

If so, maybe there is a middle ground?

Screenshot 2021-02-24 at 14 41 10

@jameskoster
Copy link
Contributor Author

Let's try the segmented control / icon approach. We can see how adding the description as a tooltip feels:

Screenshot 2021-03-02 at 11 04 43

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Mar 2, 2021
@annezazu
Copy link
Contributor

This "Advanced" section came up as part of feedback from @paaljoachim for the third FSE call for testing. For context, part of this test includes creating a custom template part for the 404 page header:

How do I give it a name. I looked into the Template Part block but could not see a way to rename it there.Ahh I had to open the Advanced panel. That is a weird place to put it. There I can rename it. Title, area and HTML element could be in an unique panel. The Advanced panel could be similar to what is seen in the Post Editor.

Right now, it does feel odd to have this living under Advanced settings when setting a name for the template part is likely the first action we should nudge a user to take so they can later tell the difference between template parts.

@paaljoachim
Copy link
Contributor

paaljoachim commented Mar 17, 2021

Thanks for the ping @annezazu

Tooltips
I am seeing that James it mentioning a kind of tooltip. I actually also mentioned this in the feedback I had for this third call for testing outreach. Having a ? in a circle or another method where one can hover a small icon to receive additional information will very much help. As there are options in the panels that are difficult to understand without any extra information.

Naming.
Here is an example from Reusable blocks.

Screen Shot 2021-03-17 at 23 46 04

The question comes up. Should we have naming in an easier place to locate? As right now it seems like one is just adding on to the Advanced panel. Here is a suggestion.

Header-name-FSE

@mtias
Copy link
Member

mtias commented Mar 18, 2021

Right now, it does feel odd to have this living under Advanced settings when setting a name for the template part is likely the first action we should nudge a user to take so they can later tell the difference between template parts.

@annezazu that would be as part of creating a new template part, which has its own flow in a modal and a very prominent "name" field. Editing an existing name should not be as prominent.

@annezazu
Copy link
Contributor

Makes sense for an existing template part but do want to point out that the current new template experience doesn't make it clear or easy to figure out where one can edit the name:

New.template.naming.flow.mov

I'll add this feedback to this issue for now: #29950

@creativecoder
Copy link
Contributor

creativecoder commented Mar 19, 2021

@jameskoster Here's a draft PR using the segmented control / icon approach suggested above.

image

It's roughed in for now, but gives a feel for using icon buttons with tooltips.

How can I find the icon for the General template option?

@jameskoster
Copy link
Contributor Author

@annezazu I think that's a separate issue warranting dedicated exploration. It could be as simple as displaying a modal when the user elects to create a new template part. Or maybe even not allowing new template part creation via the block – that has always felt like a weird flow to me.

@jameskoster
Copy link
Contributor Author

How can I find the icon for the General template option?

It's this one from the icons package :)

@jameskoster
Copy link
Contributor Author

We can potentially consider reusing the popover pattern recently implemented for the document summary panel here. E.g.

area.mp4

@paaljoachim
Copy link
Contributor

That sounds like a good idea @jameskoster

@creativecoder
Copy link
Contributor

creativecoder commented Nov 15, 2022

I've made another attempt at this in #45764 -- reviews welcome!

@jordesign
Copy link
Contributor

Checkin in WP6.3 I'm now seeing the icon indicating the Template Area in the sidebar. @jameskoster @paaljoachim do you feel like that is sufficient resolution, or should we leave this open for further refinement?

Screenshot 2023-09-08 at 12 59 32 pm

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 8, 2023
@jameskoster
Copy link
Contributor Author

@jordesign this issue is about the appearance of the area selection UI. I reckon the UI might benefit from an update to bring it more inline with the add-template modal which was updated recently:

Create template part

Screenshot 2023-09-08 at 10 27 22

Create template

Screenshot 2023-09-08 at 10 29 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants