-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template part: Area selection UI #29295
Comments
That last one seem like a lot. I can see it being useful when creating a new one from scratch, but to reassign it seems it should be simpler and assume context already (it's in "advanced" in the end). |
This "Advanced" section came up as part of feedback from @paaljoachim for the third FSE call for testing. For context, part of this test includes creating a custom template part for the 404 page header:
Right now, it does feel odd to have this living under Advanced settings when setting a name for the template part is likely the first action we should nudge a user to take so they can later tell the difference between template parts. |
Thanks for the ping @annezazu Tooltips Naming. The question comes up. Should we have naming in an easier place to locate? As right now it seems like one is just adding on to the Advanced panel. Here is a suggestion. |
@annezazu that would be as part of creating a new template part, which has its own flow in a modal and a very prominent "name" field. Editing an existing name should not be as prominent. |
Makes sense for an existing template part but do want to point out that the current new template experience doesn't make it clear or easy to figure out where one can edit the name: New.template.naming.flow.movI'll add this feedback to this issue for now: #29950 |
@jameskoster Here's a draft PR using the segmented control / icon approach suggested above. It's roughed in for now, but gives a feel for using icon buttons with tooltips. How can I find the icon for the General template option? |
@annezazu I think that's a separate issue warranting dedicated exploration. It could be as simple as displaying a modal when the user elects to create a new template part. Or maybe even not allowing new template part creation via the block – that has always felt like a weird flow to me. |
It's this one from the icons package :) |
We can potentially consider reusing the popover pattern recently implemented for the document summary panel here. E.g. area.mp4 |
That sounds like a good idea @jameskoster |
I've made another attempt at this in #45764 -- reviews welcome! |
Checkin in WP6.3 I'm now seeing the icon indicating the Template Area in the sidebar. @jameskoster @paaljoachim do you feel like that is sufficient resolution, or should we leave this open for further refinement? |
@jordesign this issue is about the appearance of the area selection UI. I reckon the UI might benefit from an update to bring it more inline with the add-template modal which was updated recently: Create template partCreate template |
When #29159 is merged it will be possible to update the
area
of the selected Template Part:Since we have dedicated icons for these areas that will be surfaced to users in the Toolbar, List View, and the Inspector, it may be worth exploring designs that incorporate them into this selection flow in order to establish holistic continuity in the UI.
One option might be to use a segmented control instead of a dropdown:
Another option would be to stick with the select but enrich the dropdown:
Whichever solution we go with, we should be aware that this element will likely exist in other environments, e.g. #29222.
The text was updated successfully, but these errors were encountered: