Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Replace template icons with template symbols #35453

Closed
jasmussen opened this issue Oct 8, 2021 · 4 comments
Closed

List View: Replace template icons with template symbols #35453

jasmussen opened this issue Oct 8, 2021 · 4 comments
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Oct 8, 2021

Followup to #34002 (comment).

New generic symbol icons for template parts and reusable blocks were introduced in 34002:

The icons are stacked to indicate that they are "linked" — editing one edits it everywhere. By sharing the overall silhouette, the relationship between template parts and reusable blocks are hinted at. They are similar, but not the same. By being generic icons reused across the list view, the structural nature of those block types become implied, clearly differentiating them from content.

The dedicated header/footer template part icons are still useful in the future template part selector:

However in the list view, the icon to denote its type should be used:
128332604-68c3c6b0-d3b0-46c0-8c5d-89304f8c3b7e

@jasmussen jasmussen added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Enhancement A suggestion for improvement. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Oct 8, 2021
@ntsekouras
Copy link
Contributor

Thanks for creating the issue Joen! I haven't looked into in depth yet, but with the current behavior the active variation's name(if exists) is shown with the help of useblockdisplayinformation. I'm not really fond of having specific handling, but I guess this should be one, in the ListView for not using this info.

@jasmussen
Copy link
Contributor Author

Thanks for looking. Since for the moment we will primarily need the actual icons to be shown in a future template type selector, perhaps we could invert the logic, and just use that same icon for those block types, and revisit to show dedicated icons in that selector in the future?

@jasmussen
Copy link
Contributor Author

@jameskoster can you glean whether following recent changes, we can close this one?

@jameskoster
Copy link
Contributor

Yes I think so. The current icon assignment for headers, footers, template parts, and patterns seems good to me.

We may need to revisit general template parts and synced patterns if those concepts merge fully, but that can probably be done in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

3 participants