Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template part: Remove transform options #29296

Closed
jameskoster opened this issue Feb 24, 2021 · 3 comments · Fixed by #42090
Closed

Template part: Remove transform options #29296

jameskoster opened this issue Feb 24, 2021 · 3 comments · Fixed by #42090
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

As surfaced in #29249, the block transform options on the Template Part block do not work.

That said, it doesn't seem sensible to allow Template Parts to be transformed in this manner at all. So rather than fix this, I vote that we remove it altogether.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 24, 2021
@carolinan
Copy link
Contributor

A conversation related to this took place on Slack (An account is needed to view it)
https://wordpress.slack.com/archives/C02QB2JS7/p1617179378083600

@Mamaduka
Copy link
Member

@ntsekouras, now that we have some logic specific to Reusable blocks and Template Parts, would it make sense to update hasPossibleBlockTransformations and add a check for the latter?

https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-switcher/index.js#L91-L93

P.S. I remember you looked into ways to disable wildcard transformations for blocks, but I don't remember the results.

@ntsekouras
Copy link
Contributor

Ideally we should augment the transforms API to handle things like excluding and better handling of the wildcard. Having said that, since we already have some specific logic there about template parts, I think it would be okay to have a stop gap solution with a good comment that this should be handled by the transforms API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants