-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag & Drop seems to be broken in Firefox when Preferences > Appearance is switched to “Display button labels” #29511
Comments
@trynet Thanks for sending in your first bug report.👏 🎉 It seems to work with Chrome. Tested it with a paragraph block or an image block Steps to reproduce:
Here is a video. TestingDragwtextlabels-Firefox.mp4What's really odd is that there is no error message in the browser console. WordPress: 5.7-RC2-50482 |
This seems to be a bug with Firefox. When using text labels, the button text is shown using an This Codepen example shows what happens in Firefox. If you try dragging the first button with text, only the words 'Drag Me' can be dragged on, dragging on any of the area outside of the text (but still inside the button) doesn't work. The second button with no text can't be dragged at all because it has no text, which is what happens with this bug: Try this in Chrome and the entire area of both buttons are draggable. I think this can be fixed by making the Drag button not use a pseudo element and have proper 'Drag' text content. Even after that, only the word 'Drag' in the button will be draggable 😬 |
@youknowriad What about this issue, i.e. is this one to be fixed for 5.7 RC3? |
Let's maybe move this to a 5.7.x release. The potential fix here looks like it might be a little risky to try at this point in the WP 5.7 release cycle. |
Agreed. |
@noisysocks Would this be an issue for the 5.7.x board? |
can confirm still an issue with Gutenberg 16.8.1 and firefox 118.0.2 |
I'll try to follow up with the firefox bug tracker. I had pretty good success recently getting another Firefox bug fixed. |
edit: that one was closed as a duplicate, this is the ticket now, which has been open for 14 years, so I'm not expecting a fix anytime soon - https://bugzilla.mozilla.org/show_bug.cgi?id=568313 |
We could possibly look at changing the draggable button to Completely changing how drag and drop works, like #23497 is another option. |
Environment:
DesktopServer PHP 7.1.13
WP 5.7-RC2-50482
Gutenberg 10.1.0
No other plugins active
Themes Tested
TwentyTwentyOne
TwentyTwenty
Hansen
FYI - The Move Up and Move Down work as expected.
The text was updated successfully, but these errors were encountered: