Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Sidebar/Inspector control improvements & allow always-collapsed menu #30370

Closed
4 of 6 tasks
Tracked by #35521
jasmussen opened this issue Mar 30, 2021 · 7 comments
Closed
4 of 6 tasks
Tracked by #35521
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Type] Enhancement A suggestion for improvement. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Mar 30, 2021

What problem does this address?

The inspector controls for the navigation block have grown organically and is deviating from proposals in #27331 and #27473 (comment) in a few ways.

Screenshot 2021-03-30 at 09 48 50

Additionally, with improvements ticketed in the following issues, it will be necessary to add some new controls:

This ticket serves to provide a path forward for the design of the navigation sidebar.

What is your proposed solution?

Screenshot 2021-03-30 at 09 34 55

A few things here, but note that each of these can happen as separate steps, and should be looked at holistically in context of #27473 and #27331:

  • Instead of adding additional panels that expand and collapse, show foundational functionality of the block right in the first panel, and retire the "Display settings".
  • Simplify and reduce the labels of the panels. "Color" instead of "Color settings",
  • Show a small preview of the mobile menu, and how it is affected by the toggles below.
  • Use a new segmented control (from Sidebar Controls & Component System #27331) to let you toggle between showing the burger never, mobile or always.

"Unfold nested submenus"

Part of this mockup is also a new toggle in the submenu category, to let you unfold nested submenus. That is, instead of having to expand out in ever expanding menus like this:

Screenshot 2021-03-30 at 10 08 39

... nested submenus would expand like this:

Screenshot 2021-03-30 at 10 09 37

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Block] Navigation Affects the Navigation Block labels Mar 30, 2021
@jasmussen jasmussen mentioned this issue Mar 30, 2021
5 tasks
@shaunandrews
Copy link
Contributor

Everything here seems super great, except for the mobile menu preview thing; I don't quite understand it's purpose, and with the design shown it's not obvious what it actually is/does.

@jasmussen
Copy link
Contributor Author

Absolutely. The "feature card" at the top is something I think will either start to make sense in a PR, and take shape as part of that, or reveal itself to not work in practice.

It is inspired by some of the Global Styles patterns and aims to elevate the sidebar from being a dull sequence of form widgets to adding some character to each block.

@mtias
Copy link
Member

mtias commented Aug 12, 2021

Where are we with this one now that the component is ready?

@jasmussen jasmussen changed the title Navigation Block: Sidebar/Inspector control improvements Navigation Block: Sidebar/Inspector control improvements & allow always-collapsed menu Aug 26, 2021
@jasmussen
Copy link
Contributor Author

There are some fresher mockups for this one here: #18395 (comment)

@jasmussen jasmussen added the [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues label Sep 15, 2021
@jasmussen
Copy link
Contributor Author

Changed this one to an overview issue, where #34783 exists as a separate ticket. I'd love to pair on that one.

@jasmussen
Copy link
Contributor Author

The recent #35568 PR actually accomplished most of what's on this list. Except for this one:

Instead of adding additional panels that expand and collapse, show foundational functionality of the block right in the first panel, and retire the "Display settings".

This item was added to embrace one of the patterns being explored for Global Styles in #34574, but is arguably best tracked separately, as it is a pattern that can/should be applied to all blocks, not just navigation. In that vein, I'm going to close this one, and follow up with a separate ticket once those pieces come into more clarity.

@mtias
Copy link
Member

mtias commented Oct 15, 2021

Another thing we don't have is the "preview". Also using it in practice I think we can add more contextual info for each state. (As in, update the help description based on what option is set to better communicate what is going on.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Type] Enhancement A suggestion for improvement. [Type] Overview Comprehensive, high level view of an area of focus often with multiple tracking issues
Projects
None yet
Development

No branches or pull requests

4 participants