-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block Tracking Issue #27593
Comments
@draganescu for "Support drag and drop to reorder blocks in list view" shouldn't we be pointing to #25067 instead? (or maybe a separate issue to enable drag and drop for the block list view, as it's already working on the Navigation screen.) #19703 isn't about list view but the actual block interface. |
Thanks for catching that @tellthemachines 👍 I've corrected the link. |
Circling back to this issue, since it has been mentioned in the Editor chat summary 27th January. The list above contains no indications on how menus will be shared between templates. An example would be a main navigation, which would be present on every template. Right now you can use a template part for this. Will this be the way going forward? |
I think that's so far the most logical conclusion. It might make sense to add "navigation" as one of the validated terms for #27337 and automatically create such parts upon menu creation if we can reduce unnecessary UX overhead. One thing that is not entirely clear yet is how independent navigation should be from the header and whether that should always be the case regardless of how the menu is built. For example, in some themes header and navigation would be virtually indistinguishable and creating further template parts would seem a hindrance. Some themes with complex mega-menus, the navigation would also be the header. However, in cases where the menu is a simple list of the root pages its reusability as is becomes a lot more desirable. |
Good catch, I corrected the link to the separator issue, it was #23293. |
Recent additions like the Page List block, and the incoming menu item setup state (#28440), take giant steps toward a better user experience. At some point, we'll want to create patterns that leverage the navigation block, so we can visualize the variety of different navigation menu designs possible. Currently the divergence in markup between front and backend makes that tricky, and the following efforts would help that a lot:
Both these efforts will benefit the navigation block structure and styling, including patterns. It might even make some of the other tasks easier to address also. |
Added #29036 to the list. |
Is there any plan to increase the priority of #24644? It is in the high priority section, but right down at the bottom. At the moment the Navigation block has lots of invalid markup when the following (non
#24644 is supposed to resolve that by removing the nav block's |
To improve the legibility, I edited this one a little bit:
A couple of the items could use clarification:
|
I believe #27337 and mtias' comment above provide the context for that. It is not actionable yet, though, so there is no specific ticket, but I'll link the issue as a context in the top comment 👍 |
Regarding flyout submenus in the Navigation block, there is #29101. Is that what "Flyout submenus" in the list refers to? |
I lowered the priority of "Allow insert before / after: #23603". It's a task that needs addressing, but it does not seem as high priority as all the others. |
I added #28575 to the list as high priority, because we need to level the playing field between menu items generated by the Page List block, and regular menu items: |
I checked off "Flyout menus", as #29932 has landed, if that item referred to additional things, please feel free to uncheck. |
Added "Add an API to retrieve content-only inner blocks" #30674 to the list |
Added:
|
I've created a Project Board as suggested by @gwwar to easier identify PRs needing review, and added all pending issues and most PRs to it. Feel free to add/tweak columns as needed! 🙂 |
Awesome, thanks @priethor ! |
Checked off "Allow folding of nested items" thanks to @gwwar 🥇 |
There's been a conversation about enabling more diverse navigation block patterns, that provide highly opinionated defaults, for example site navigations that show exactly 3 menu items, a site logo, and instagram/facebook/twitter links. Perhaps even with the navigation items pre-labelled. To enable such patterns, the setup/placeholder state for the navigation block needs to be reconsidered with a focus on menu item setup states instead. Consider these: Those are intrinsically opinionated patterns, and should be allowed to lean into that, just like we already do for Button patterns: The buttons above have their labels pre-filled, but they link no-where. You could think of that as an "opinionated Buttons block pattern", and we need to be able to accommodate similarly opinionated ones for the navigation block. Only, it also needs to be much clearer that those buttons really do link no-where, and that you need to point them to their destinations, or they won't be very useful. This is particularly important for the navigation block, and we have a neat little trio of tickets that, when addressed together, should get us pretty far on that:
While those three tickets are not crucially urgent for the overall navigation block "phase 1" as outlined here, they are nevertheless important to address on our navigation block journey, and the solutions we find here can benefit not just Navigation, but also Buttons and potentially Social Links as well. I'll add these three items to the navigation block board, as a start, but for anyone reading, let me know if we should add them to the body of this ticket as well. |
On behalf of @tellthemachines I checked the box for "Multiple blocks available". 👏 |
On behalf of @georgeh I checked the "Add a separate color overlay option" 🏅 |
For anyone reading, I wanted to tease that the task, "Allow insert before / after", will almost certainly be fixed as a side-effect of addressing #34041 and the proposed mockups, which entail creating a "default" block that you insert instantly. |
Related to link color settings missing or not working: #34648 |
As the items in this issue are complete for the most part, I've created #35521 as the next iteration on Navigation Block improvements. Let's continue there and keep this issue as a first iteration snapshot. |
🚀 |
Extends #24551
This is an overview issue that we'll maintain going forward into WP 5.5 and 5.6 milestones. It attempts to track discussions and resulting actions about the Navigation Block.
This overview does not track bugs of the Navigation Block, for that you should filter open issues using the labels [Block] Navigation and [Type]Bug.
🏷 High
List View
Blocks
Navigation: Next steps for supporting non-links in Navigation block and screen #24364, Navigation Block: Support non-li inner blocks #29036).Editing
NavigationMenu: set appender color #18327NavigationLink: make the URL dynamic for links to Posts #18345Navigation Menu: render item without link #18442Navigation block: can't unlink items #18866LinkControl - ensure minmum loading UI display when Creating a new suggestion via).createSuggestion
#20138[ Navigation block ] Hide the empty Links in Navigation when the block is not selected #21848)Customization
a
tag for menu items Navigation Block: Try contenteditable anchor (a
) markup #28575API
🏷 Normal
Blocks
Customization
The text was updated successfully, but these errors were encountered: