Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Menu item placeholder inheritance. #32512

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

jasmussen
Copy link
Contributor

Description

In #32373 we are discussing how the navigation block placeholder state can be improved. As part of the conversation, one idea is to de-emphasize the overall navigation block placeholder state — after all, navigation can contain both links, spacers, search, social links — and instead focus in the menu item placeholder state.

We already have one such, it looks like this:

before

This PR leverages that, but adds font, style and color inheritance, as well as a grammar-like wavy underline to indicate this item needs attention:

after

I'm not entirely happy with the style of the wavy underline, and I'm exploring better alternatives in this codepen. Nevertheless the benefit of doing it this way is that it inherits color, making it work well on other theme backgrounds. Here are two twenties:

after tt1

after tt

Note, this PR is in a draft state because it is only an initial step at exploring the feasibility, the pros, and the cons of this appraoch. If we think there's potential — already in testing this branch, I'm rather convinced there is — it should be taken a few steps further:

  • The block should stay in a setup state until both URL and Label are filled out
  • At the moment, the placeholder requires a URL before you can set a label. We will likely need a new or enhanced link popover which also allows changing the label, but not set the URL, for creating patterns and avoiding the "Select a page".
  • The setup state could/should expand to other "button blocks", such as Buttons and Social Links, so it should be a reusable generic component
  • If you clear a link to a button block, or if you remove a label, the block reverts to its "placeholder state", i.e. the squiggly line returns, and the URL/Label picker opens immediately on click.

Depending on our approach, we can potentially defer some of those changes, but they are nevertheless part of the idea.

How has this been tested?

Please insert a navigation block, start empty, and then insert page links or custom URLs or any other menu item links. But instead of choosing a page or pasting a URL in the dialog that follows, press Escape to close it.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@jasmussen jasmussen added the [Block] Navigation Affects the Navigation Block label Jun 8, 2021
@jasmussen jasmussen requested a review from kjellr June 8, 2021 12:03
@jasmussen jasmussen self-assigned this Jun 8, 2021
@jasmussen
Copy link
Contributor Author

jasmussen commented Jun 8, 2021

I would encourage reviewers to give this PR a run and not just look at the GIFs. Here's a convenient Gutenberg-run URL: http://gutenberg.run/32512

To me, it feels much better in practice than it looks. The wavy underlines immediately stand out as "needing attention", and clicking them and being immediately met with a choice to rectify that, feels very natural.

Here's some test content you can also start with:

<!-- wp:navigation {"orientation":"horizontal"} -->
<!-- wp:navigation-link {"label":"Home","type":"page","id":11,"url":"http://localhost:8888/","kind":"post-type"} /-->

<!-- wp:navigation-link {"label":"About","type":"page","id":648,"url":"http://localhost:8888/?page_id=648","kind":"post-type"} -->
<!-- wp:navigation-link {"label":"Qualities","type":"page","id":658,"url":"http://localhost:8888/?page_id=658","kind":"post-type"} /-->

<!-- wp:navigation-link {"label":"Properties","type":"page","id":657,"url":"http://localhost:8888/?page_id=657","kind":"post-type"} /-->

<!-- wp:navigation-link {"type":"page","kind":"post-type"} /-->

<!-- wp:navigation-link {"type":"page","kind":"post-type"} /-->
<!-- /wp:navigation-link -->

<!-- wp:navigation-link {"type":"page","kind":"post-type"} /-->

<!-- wp:navigation-link {"type":"page","kind":"post-type"} /-->
<!-- /wp:navigation -->

As a next step, I will try to explore better wavy underlines. I'd love to provide a lovely SVG, but make sure it inherits colors.

@jasmussen jasmussen requested review from georgeh and gwwar June 8, 2021 12:05
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Size Change: -324 B (0%)

Total Size: 1.06 MB

Filename Size Change
build/block-library/blocks/navigation-link/editor-rtl.css 474 B -159 B (-25%) 🎉
build/block-library/blocks/navigation-link/editor.css 473 B -161 B (-25%) 🎉
build/block-library/editor-rtl.css 9.85 kB -1 B (0%)
build/block-library/editor.css 9.84 kB -1 B (0%)
build/block-library/index.min.js 146 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 1.12 kB
build/admin-manifest/index.min.js 1.42 kB
build/annotations/index.min.js 2.93 kB
build/api-fetch/index.min.js 2.44 kB
build/autop/index.min.js 2.28 kB
build/blob/index.min.js 673 B
build/block-directory/index.min.js 6.61 kB
build/block-directory/style-rtl.css 1.02 kB
build/block-directory/style.css 1.02 kB
build/block-editor/index.min.js 120 kB
build/block-editor/style-rtl.css 14 kB
build/block-editor/style.css 13.9 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 112 B
build/block-library/blocks/audio/style.css 112 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 475 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/button/style-rtl.css 603 B
build/block-library/blocks/button/style.css 602 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/buttons/style-rtl.css 375 B
build/block-library/blocks/buttons/style.css 375 B
build/block-library/blocks/calendar/style-rtl.css 208 B
build/block-library/blocks/calendar/style.css 208 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 190 B
build/block-library/blocks/columns/editor.css 190 B
build/block-library/blocks/columns/style-rtl.css 475 B
build/block-library/blocks/columns/style.css 476 B
build/block-library/blocks/cover/editor-rtl.css 670 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/cover/style-rtl.css 1.22 kB
build/block-library/blocks/cover/style.css 1.23 kB
build/block-library/blocks/embed/editor-rtl.css 486 B
build/block-library/blocks/embed/editor.css 486 B
build/block-library/blocks/embed/style-rtl.css 401 B
build/block-library/blocks/embed/style.css 400 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 301 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 779 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 704 B
build/block-library/blocks/gallery/editor.css 705 B
build/block-library/blocks/gallery/style-rtl.css 1.06 kB
build/block-library/blocks/gallery/style.css 1.06 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 160 B
build/block-library/blocks/group/editor.css 160 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 93 B
build/block-library/blocks/group/theme.css 93 B
build/block-library/blocks/heading/editor-rtl.css 152 B
build/block-library/blocks/heading/editor.css 152 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/home-link/style-rtl.css 259 B
build/block-library/blocks/home-link/style.css 259 B
build/block-library/blocks/html/editor-rtl.css 281 B
build/block-library/blocks/html/editor.css 281 B
build/block-library/blocks/image/editor-rtl.css 729 B
build/block-library/blocks/image/editor.css 727 B
build/block-library/blocks/image/style-rtl.css 481 B
build/block-library/blocks/image/style.css 485 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 286 B
build/block-library/blocks/latest-comments/style.css 286 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 534 B
build/block-library/blocks/latest-posts/style.css 532 B
build/block-library/blocks/list/style-rtl.css 63 B
build/block-library/blocks/list/style.css 63 B
build/block-library/blocks/media-text/editor-rtl.css 263 B
build/block-library/blocks/media-text/editor.css 264 B
build/block-library/blocks/media-text/style-rtl.css 492 B
build/block-library/blocks/media-text/style.css 489 B
build/block-library/blocks/more/editor-rtl.css 434 B
build/block-library/blocks/more/editor.css 434 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation/editor-rtl.css 1.69 kB
build/block-library/blocks/navigation/editor.css 1.69 kB
build/block-library/blocks/navigation/style-rtl.css 1.65 kB
build/block-library/blocks/navigation/style.css 1.65 kB
build/block-library/blocks/navigation/view.min.js 2.87 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 310 B
build/block-library/blocks/page-list/editor.css 311 B
build/block-library/blocks/page-list/style-rtl.css 240 B
build/block-library/blocks/page-list/style.css 240 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 247 B
build/block-library/blocks/paragraph/style.css 248 B
build/block-library/blocks/post-author/editor-rtl.css 209 B
build/block-library/blocks/post-author/editor.css 209 B
build/block-library/blocks/post-author/style-rtl.css 183 B
build/block-library/blocks/post-author/style.css 184 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-content/editor-rtl.css 139 B
build/block-library/blocks/post-content/editor.css 139 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B
build/block-library/blocks/post-featured-image/editor.css 338 B
build/block-library/blocks/post-featured-image/style-rtl.css 141 B
build/block-library/blocks/post-featured-image/style.css 141 B
build/block-library/blocks/post-template/editor-rtl.css 100 B
build/block-library/blocks/post-template/editor.css 99 B
build/block-library/blocks/post-template/style-rtl.css 379 B
build/block-library/blocks/post-template/style.css 380 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B
build/block-library/blocks/pullquote/editor.css 183 B
build/block-library/blocks/pullquote/style-rtl.css 318 B
build/block-library/blocks/pullquote/style.css 318 B
build/block-library/blocks/pullquote/theme-rtl.css 169 B
build/block-library/blocks/pullquote/theme.css 169 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B
build/block-library/blocks/query-pagination/editor.css 262 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B
build/block-library/blocks/query-pagination/style.css 168 B
build/block-library/blocks/query-title/editor-rtl.css 86 B
build/block-library/blocks/query-title/editor.css 86 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 169 B
build/block-library/blocks/quote/style.css 169 B
build/block-library/blocks/quote/theme-rtl.css 221 B
build/block-library/blocks/quote/theme.css 221 B
build/block-library/blocks/rss/editor-rtl.css 201 B
build/block-library/blocks/rss/editor.css 202 B
build/block-library/blocks/rss/style-rtl.css 290 B
build/block-library/blocks/rss/style.css 290 B
build/block-library/blocks/search/editor-rtl.css 211 B
build/block-library/blocks/search/editor.css 211 B
build/block-library/blocks/search/style-rtl.css 359 B
build/block-library/blocks/search/style.css 362 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 251 B
build/block-library/blocks/separator/style.css 251 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 476 B
build/block-library/blocks/shortcode/editor.css 476 B
build/block-library/blocks/site-logo/editor-rtl.css 465 B
build/block-library/blocks/site-logo/editor.css 465 B
build/block-library/blocks/site-logo/style-rtl.css 154 B
build/block-library/blocks/site-logo/style.css 154 B
build/block-library/blocks/site-tagline/editor-rtl.css 87 B
build/block-library/blocks/site-tagline/editor.css 87 B
build/block-library/blocks/site-title/editor-rtl.css 85 B
build/block-library/blocks/site-title/editor.css 85 B
build/block-library/blocks/social-link/editor-rtl.css 164 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/social-links/editor-rtl.css 800 B
build/block-library/blocks/social-links/editor.css 799 B
build/block-library/blocks/social-links/style-rtl.css 1.34 kB
build/block-library/blocks/social-links/style.css 1.34 kB
build/block-library/blocks/spacer/editor-rtl.css 308 B
build/block-library/blocks/spacer/editor.css 308 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 478 B
build/block-library/blocks/table/editor.css 478 B
build/block-library/blocks/table/style-rtl.css 480 B
build/block-library/blocks/table/style.css 480 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B
build/block-library/blocks/tag-cloud/editor.css 118 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B
build/block-library/blocks/tag-cloud/style.css 94 B
build/block-library/blocks/template-part/editor-rtl.css 551 B
build/block-library/blocks/template-part/editor.css 550 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 569 B
build/block-library/blocks/video/editor.css 570 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 1.29 kB
build/block-library/common.css 1.29 kB
build/block-library/reset-rtl.css 514 B
build/block-library/reset.css 515 B
build/block-library/style-rtl.css 10.2 kB
build/block-library/style.css 10.2 kB
build/block-library/theme-rtl.css 692 B
build/block-library/theme.css 693 B
build/block-serialization-default-parser/index.min.js 1.3 kB
build/block-serialization-spec-parser/index.min.js 3.06 kB
build/blocks/index.min.js 47.2 kB
build/components/index.min.js 194 kB
build/components/style-rtl.css 16.1 kB
build/components/style.css 16.1 kB
build/compose/index.min.js 10.2 kB
build/core-data/index.min.js 12.4 kB
build/customize-widgets/index.min.js 10.3 kB
build/customize-widgets/style-rtl.css 1.48 kB
build/customize-widgets/style.css 1.48 kB
build/data-controls/index.min.js 830 B
build/data/index.min.js 7.22 kB
build/date/index.min.js 31.8 kB
build/deprecated/index.min.js 739 B
build/dom-ready/index.min.js 577 B
build/dom/index.min.js 4.66 kB
build/edit-navigation/index.min.js 13.9 kB
build/edit-navigation/style-rtl.css 3.12 kB
build/edit-navigation/style.css 3.12 kB
build/edit-post/classic-rtl.css 483 B
build/edit-post/classic.css 483 B
build/edit-post/index.min.js 58.7 kB
build/edit-post/style-rtl.css 7.25 kB
build/edit-post/style.css 7.24 kB
build/edit-site/index.min.js 25.9 kB
build/edit-site/style-rtl.css 5.04 kB
build/edit-site/style.css 5.03 kB
build/edit-widgets/index.min.js 16.2 kB
build/edit-widgets/style-rtl.css 3.88 kB
build/edit-widgets/style.css 3.89 kB
build/editor/index.min.js 38.6 kB
build/editor/style-rtl.css 3.88 kB
build/editor/style.css 3.88 kB
build/element/index.min.js 3.44 kB
build/escape-html/index.min.js 739 B
build/format-library/index.min.js 5.71 kB
build/format-library/style-rtl.css 668 B
build/format-library/style.css 669 B
build/hooks/index.min.js 1.76 kB
build/html-entities/index.min.js 629 B
build/i18n/index.min.js 3.73 kB
build/is-shallow-equal/index.min.js 709 B
build/keyboard-shortcuts/index.min.js 1.74 kB
build/keycodes/index.min.js 1.43 kB
build/list-reusable-blocks/index.min.js 2.07 kB
build/list-reusable-blocks/style-rtl.css 842 B
build/list-reusable-blocks/style.css 842 B
build/media-utils/index.min.js 3.08 kB
build/notices/index.min.js 1.07 kB
build/nux/index.min.js 2.31 kB
build/nux/style-rtl.css 745 B
build/nux/style.css 742 B
build/plugins/index.min.js 1.99 kB
build/primitives/index.min.js 1.03 kB
build/priority-queue/index.min.js 791 B
build/react-i18n/index.min.js 925 B
build/redux-routine/index.min.js 2.82 kB
build/reusable-blocks/index.min.js 2.56 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.6 kB
build/server-side-render/index.min.js 1.64 kB
build/shortcode/index.min.js 1.68 kB
build/token-list/index.min.js 847 B
build/url/index.min.js 1.95 kB
build/viewport/index.min.js 1.28 kB
build/warning/index.min.js 1.13 kB
build/widgets/index.min.js 6.45 kB
build/widgets/style-rtl.css 1.04 kB
build/widgets/style.css 1.05 kB
build/wordcount/index.min.js 1.24 kB

compressed-size-action

@jasmussen
Copy link
Contributor Author

I found a way to make a prettier wavy underline in #32579, but alas it doesn't work with wrapping text.

@kjellr
Copy link
Contributor

kjellr commented Jun 18, 2021

This one feels more natural to me than #32578.

The wiggly underline might get confusing when combined with browser/OS grammar checks (since they often also impose an underline), however I'm not sure this would end up being applied to user-entered text, right? In the PR at least, it's only applied to block placeholders (which we control the text for). This could work if we had logic that would validate any links in a pattern to see it matched with an existing post/page on insert. If it did not, then Gutenberg could transform that block into a placeholder.

So for example, a pattern could define a navigation block like this, and this is what would show up in the pattern preview:

Screen Shot 2021-06-18 at 11 23 54 AM

But when a user inserted that pattern, it would show up like this:

Screen Shot 2021-06-18 at 11 24 15 AM

The "Home Link" block would still work, since we can resolve that. But the other two pages would automatically revert to placeholders.

Does that generally make sense?

@jasmussen
Copy link
Contributor Author

Thank you for looking, Kjell.

While I'm starting here with the Navigation block because it has part of this setup state built, what I'm essentially looking for is a general design that we can use across all blocks, including Buttons and others. In other words, I want the design to work for this pattern as well:

Screenshot 2021-06-21 at 09 23 15

Having slept a few days on the squiggly line, I'm also doubting it myself now. I'll keep thinking.

But to answer your question, I think the preview and what you insert should be identical, give or take a few small additions. So in your examples, the Home, About and Contact would keep their labels. The only addition would be the squiggly line, point being we could apply the squiggly line to "Our Work" or "Where We Are" buttons as well. It could theoretically even work for a random link to # in the prose of a paragraph of text.

The reason I think it's important to retain the pattern-definded text/labels is to both meet expectations you have when you see the pattern, but also to enable and encourage super opinionated patterns. Someone opening a pet store might look for a photo of a dog and clinic related labels in patterns. And while they can and should edit things, I think there's value there.

@kjellr
Copy link
Contributor

kjellr commented Jun 21, 2021

The reason I think it's important to retain the pattern-definded text/labels is to both meet expectations you have when you see the pattern, but also to enable and encourage super opinionated patterns. Someone opening a pet store might look for a photo of a dog and clinic related labels in patterns. And while they can and should edit things, I think there's value there.

Thanks for that example — that makes sense.

@jasmussen jasmussen force-pushed the try/menu-item-placeholder-inheritance branch 2 times, most recently from 3fa94e4 to 352ac86 Compare June 22, 2021 12:26
@jasmussen
Copy link
Contributor Author

Okay, I pushed some polish and some tweaks to this one. I improved the wavy underline, abstracted the way it's built, and added in opacity. I think it's working fairly well, and I genuinely think it's worth trying. Here's how it looks:

status

The color is inherited in the underline:

colored

It'd be nice to explore a next step of letting the menu item stay in a placeholder state, even if the label has been filled out. That should be the key pattern enabler.

@jasmussen jasmussen marked this pull request as ready for review June 22, 2021 12:29
@jasmussen jasmussen force-pushed the try/menu-item-placeholder-inheritance branch 2 times, most recently from a1dbeba to a938a9d Compare June 28, 2021 14:26
@jasmussen
Copy link
Contributor Author

Rebased and tried this one again. I actually think it's worth trying, because it's mostly CSS. Here's a high res screenshot of a quickly cobbled together "pattern":

Screenshot 2021-06-28 at 16 26 07

@jasmussen
Copy link
Contributor Author

I'd really like to land this one. It removes more CSS than it adds, and and it allows menu items to inherit styles, which on its own is valuable too. If we find the wavy underline doesn't work, we can leverage the MacOS grammar style:

Screenshot 2021-07-07 at 12 03 13

That would be an easy followup patch to do to this one. @kjellr or @georgeh got any green checkmarks lying around?

// Provide a little margin to show each placeholder as a separate unit.
margin: 2px;
// Appear disabled to indicate incompleteness.
opacity: 0.6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this opacity effect is going to work if we apply it to the theme's colors. In Twenty Twenty for example, it results in text that doesn't pass AA contrast:

Screen Shot 2021-07-07 at 12 02 13 PM

I expect this would be similar in any theme that uses a text color that isn't relatively high contrast by default. Do you think this works nicely if we remove the opacity effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought, I removed it for now. I think it might be worth to revisit this, or a variant of this, to indicate some form of "interactivity" that feels a bit lost without it. But I'd love to do that separately.

@jasmussen jasmussen force-pushed the try/menu-item-placeholder-inheritance branch from a938a9d to f5c7212 Compare July 8, 2021 07:47
@jasmussen
Copy link
Contributor Author

Thanks so much for looking. I'll and this and will always be happy to follow up.

@jasmussen jasmussen merged commit e22bfb8 into trunk Jul 9, 2021
@jasmussen jasmussen deleted the try/menu-item-placeholder-inheritance branch July 9, 2021 09:16
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 9, 2021
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
* Try: Menu item placeholder inheritance.

* Simplify and polish the waviness.

* Remove opacity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants