Try: Alternate menu item setup state with inheritance. #32578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -96 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
7 tasks
|
Closing in favor of #32512. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #32512, but hopes to accomplish the same: provide indication that a menu item is in an incomplete state, but still allow inheritance of font and color so as to allow more elaborate patterns.
This one was inspired by the error state in the Macos finder where a partial character, ¨, is used. Or more specifically — that umlaut isn't meant to stand alone, you press it first, then press the character it is meant to overlay. The finder shows a colored background until the character is complete:
This branch is currently using
currentColorbut with an elaborate CSS filter applied to accomplish a color that should work in most contexts — but I'm still tinkering with that bit. But here's what it looks like:Checklist:
*.native.jsfiles for terms that need renaming or removal).