-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Publicize missing from side panels #3264
Comments
Related: #1352 (Possible duplicate) |
Yeah, Publicize isn't specifically mentioned there as it's just a more general idea of how the screen should be configured. With the recent Gutenberg releases third party meta boxes, etc, have all appeared but Publicize is noticeably absent - I suspect it's because any changes to the primary meta box (the one in the standard editor with the publishing options in) have not yet been picked up in the new layout. |
Thank you for the report, this should be fixable. |
Related Automattic/jetpack#7766 |
This is primarily a Jetpack/Publicize issue. I suggest closing #3264 in favor of this newly created issue in the Jetpack repo: Automattic/jetpack#9039 |
@c-shultz, it looks like the plan includes making pre and pot-publish screen extensible so it makes sense to keep this issue open to discuss technical details required on the Gutenberg side to make it done. Leaving some related PRs for reference:
There are plenty of options how this can be fone for the publish flow. We need to investigate what we need first and pick one of the solutions. Let me know what you think. |
Many thanks, @gziolo, for putting this list together! I'm going to nail the design approach down a little more with @MichaelArestad and then I'll get back to you on these. |
@gziolo, I'm going to pursue making this work in the post-publish view. That's the most desired path for this based on the design mock-ups and discussion. There's a couple challenges to making that work (I'll make another post about that). If any of that falls through, putting this in pre-publish will be a good fallback. For post-publish, #3321 that you mentioned looks like it would be close to what we need. I see that you closed that in favor of another approach? I wasn't clear on what that approach was. Let me know what you need from me. Do you plan to develop the Gutenberg side to expose the right hooks? I'm up for learning whatever to get this done (just trying to get a feel for where it makes sense for my responsibility to fit in). |
There's another potential Gutenberg change that I described in a recent post in Automattic/jetpack#9039. The crux of it is that, for the post-publish flow, I need Publicize to know that a published post is coming from Gutenberg (as opposed to the Classic Editor, API, etc.).
Scratch that. Based on feedback in Automattic/jetpack#9039, I'm going to look into calling an endpoint to write a meta key just before Gutenberg publishes. My plan is to have a pretty solid first iteration on the Jetpack/Publicize backend after this weekend, and then work on the Gutenberg integration over next weekend. I'll plan on working to implement the necessary hooks to make this happen (I'll use #3321 as a rough guide to get started). |
Sharing an update. There was new API introduced for Plugins which seems to be the preferred way to add all UI based extensions. See: https://github.com/WordPress/gutenberg/blob/master/plugins/README.md#plugins-api. I would recommend checking it and explore if it could be also used for the post-publish screen. It could look something like: const { PluginPostPublish } = wp.editPost.__experimental;
const { registerPlugin } = wp.plugins;
const Component = () => (
<PluginPostPublish name="publicize" title="Publicize">
Content of the publicize
</PluginPostPublish>
);
registerPlugin( 'jetpack', {
render: Component,
} ); I have no idea what you really need so I simply updated the existing example to give you a better idea what I'm talking about. |
Thanks, @gziolo! I'll explore this over the weekend. I don't yet see any reason that this wouldn't work for what I need. |
It is now possible to implement with API introduced in #6798. |
Any news on this? |
The original bug report was that the publicize controls from the Classic editor were absent from Gutenberg, notably the ability to edit the text of what would be published to connected social media accounts. The bug has been marked 'done' because the API now permits the missing features to be added. However, the original intent of the bug report has been lost as the publicize features remain absent from Gutenberg. Can this report be reopened, or a new one filed to restore the missing publicize features, please? Edit: I've opened #10311 |
I have the Jetpack Publicize feature switched on but, at the moment, when editing a post with Guternberg, I don't have meta boxes available to me to edit this information - I end up resorting to switching to the standard editing mode just to set this up before publishing (I rarely publish without changing the publicize text).
With most of my other meta boxes now picked up in the latest Gutenberg releases, I was surprised to find this one missing, particularly as it's a Jetpack addition.
I'm running WordPress 4.8.2, Gutenberg 1.5.2.
The text was updated successfully, but these errors were encountered: