Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect decoding Site Title in pre-publish checklist UI #34092

Closed
2 tasks done
JJJ opened this issue Aug 16, 2021 · 5 comments
Closed
2 tasks done

Incorrect decoding Site Title in pre-publish checklist UI #34092

JJJ opened this issue Aug 16, 2021 · 5 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@JJJ
Copy link
Contributor

JJJ commented Aug 16, 2021

Description

I have an apostrophe in my blog title: JJJ's Blog. That apostrophe is oddly decoded in the prepublish UI.

Step-by-step reproduction instructions

  1. WordPress Admin > Settings > General > Site Title > Put an apostrophe ' here
  2. Enable "Include pre-publish checklist" preference
  3. Write a blog post using Gutenberg
  4. Click "Publish"
  5. Notice that the ' is decoded to '

Screenshots, screen recording, code snippet

Settings

jjj-on-2021-08-16-at-11-55-17@2x

Are you ready to publish?

jjj-on-2021-08-16-at-11-44-41@2x

Environment info

WordPress 5.8
Bundled Gutenberg version
Twenty Twenty-One theme
Any operating system

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@JJJ
Copy link
Contributor Author

JJJ commented Aug 16, 2021

Line of code:

{ decodeEntities( siteTitle ) || __( '(Untitled)' ) }

@JJJ
Copy link
Contributor Author

JJJ commented Aug 16, 2021

Related: #33321, #33323.

@annezazu annezazu added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. labels Aug 16, 2021
@annezazu
Copy link
Contributor

Thanks for reporting, finding the line of code, and sharing related issues <3 @walbo it looks like you worked on this recently -- perhaps you can check this out too? :)

@walbo
Copy link
Member

walbo commented Aug 16, 2021

Did a quick test and I belive #33323 fixed this issue in Gutenberg. I do see the entities when running WP 5.8 without Gutenberg (looks like that is enviroment you are running).

I'm not sure how the process is when it comes to backporting PR's to minor WP releases but maybe #33323 should be included in WP 5.8.1?

@Mamaduka
Copy link
Member

The issue should be resolved now. Props to @walbo.

CleanShot 2022-05-10 at 09 02 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants