-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode entities in site title #33323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works as expected. I just request few minor changes hope you don't mind. 🙇
packages/edit-site/src/components/navigation-sidebar/navigation-panel/index.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/prepublish.js
Outdated
Show resolved
Hide resolved
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
@walbo, sorry for the confusion. I didn't recommend decoding |
Ah. My mistake. I will revert that one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, and thanks for the quick updates, @walbo.
It's always a pleasure reviewing your PRs.
Description
Fixes #33321
How has this been tested?
Locally. Added a site title that have characters that are going to be encoded and confirmed is shows correctly in the locations described in #33321.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).