Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode entities in site title #33323

Merged
merged 6 commits into from
Jul 13, 2021
Merged

Conversation

walbo
Copy link
Member

@walbo walbo commented Jul 9, 2021

Description

Fixes #33321

How has this been tested?

Locally. Added a site title that have characters that are going to be encoded and confirmed is shows correctly in the locations described in #33321.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@walbo walbo requested a review from ajitbohra as a code owner July 9, 2021 08:15
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works as expected. I just request few minor changes hope you don't mind. 🙇

Petter Walbø Johnsgård and others added 2 commits July 12, 2021 18:40
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
@Mamaduka
Copy link
Member

@walbo, sorry for the confusion. I didn't recommend decoding readOnlyTitle on render because it's used in a few places and decoding once, in this case, makes more sense.

@walbo
Copy link
Member Author

walbo commented Jul 12, 2021

Ah. My mistake. I will revert that one.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, and thanks for the quick updates, @walbo.

It's always a pleasure reviewing your PRs.

@Mamaduka Mamaduka added [Block] Site Title Affects the Site Title Block [Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended labels Jul 13, 2021
@Mamaduka Mamaduka merged commit 54e8671 into WordPress:trunk Jul 13, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 13, 2021
@walbo walbo deleted the site-title-encode branch July 13, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block [Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site title renders escaped characters in multiple locations
2 participants