-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View: Slow group deletion #34310
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Comments
gwwar
added
[Type] Bug
An existing feature does not function as intended
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
labels
Aug 25, 2021
github-actions
bot
added
the
[Status] In Progress
Tracking issues with work in progress
label
Sep 1, 2021
This one should be fixed by #34519 |
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Status] In Progress
Tracking issues with work in progress
[Type] Bug
An existing feature does not function as intended
Description
In larger posts, if we delete nested blocks we can see the block icon and title disappearing before the rows are removed. Ideal behavior would quickly remove all deleted nodes in the list view.
Note that we can see a "fast" delete if we perform an action like, undo, then delete, or paste then delete.
I dug a bit into this one, and what's happening is that the
clientIdsTree
in ListView is only updated after all child buttons/block titles update. 🤔 I didn't have much luck with triggering a parent update, even when selecting for additional data like block order. We may want to dig into why behavior is different for a paste -> delete, or undo -> delete.Step-by-step reproduction instructions
Expected: The rows are quickly removed in one go.
Actual: The block icon and title disappears first. Removal of rows is slow.
Screenshots, screen recording, code snippet
slow.remove.mp4
Environment info
Gutenberg master (3f2593f)
Pre-checks
The text was updated successfully, but these errors were encountered: