Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View: Slow group deletion #34310

Closed
2 tasks done
gwwar opened this issue Aug 25, 2021 · 1 comment
Closed
2 tasks done

List View: Slow group deletion #34310

gwwar opened this issue Aug 25, 2021 · 1 comment
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@gwwar
Copy link
Contributor

gwwar commented Aug 25, 2021

Description

In larger posts, if we delete nested blocks we can see the block icon and title disappearing before the rows are removed. Ideal behavior would quickly remove all deleted nodes in the list view.

Note that we can see a "fast" delete if we perform an action like, undo, then delete, or paste then delete.

I dug a bit into this one, and what's happening is that the clientIdsTree in ListView is only updated after all child buttons/block titles update. 🤔 I didn't have much luck with triggering a parent update, even when selecting for additional data like block order. We may want to dig into why behavior is different for a paste -> delete, or undo -> delete.

Step-by-step reproduction instructions

Screen Shot 2021-08-25 at 3 34 22 PM

  1. Open the post editor
  2. Open list view
  3. Make sure the post is somewhat larger, with a lot of nested content. (Drag a few patterns)
  4. Delete a block with a lot of children

Expected: The rows are quickly removed in one go.
Actual: The block icon and title disappears first. Removal of rows is slow.

Screenshots, screen recording, code snippet

slow.remove.mp4

Environment info

Gutenberg master (3f2593f)

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@gwwar gwwar added [Type] Bug An existing feature does not function as intended [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Aug 25, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 1, 2021
@gwwar
Copy link
Contributor Author

gwwar commented Sep 20, 2021

This one should be fixed by #34519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant