Try disabling async mode provider around selected block in ListView #34519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] List View
|
Size Change: +19 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
talldan
commented
Sep 3, 2021
Comment on lines
+89
to
+110
| const expand = useCallback( | ||
| ( clientId ) => { | ||
| if ( ! clientId ) { | ||
| return; | ||
| } | ||
| setExpandedState( { type: 'expand', clientId } ); | ||
| }, | ||
| [ setExpandedState ] | ||
| ); | ||
| const collapse = useCallback( | ||
| ( clientId ) => { | ||
| if ( ! clientId ) { | ||
| return; | ||
| } | ||
| setExpandedState( { type: 'collapse', clientId } ); | ||
| }, | ||
| [ setExpandedState ] | ||
| ); |
There was a problem hiding this comment.
These are used in a context provider, so I think they should be memoized to stop the consumers from constantly updating.
talldan
commented
Sep 3, 2021
| @@ -125,7 +131,7 @@ function ListView( | |||
| ); | |||
|
|
|||
| return ( | |||
| <> | |||
| <AsyncModeProvider value={ true }> | |||
There was a problem hiding this comment.
I suppose this could be <AsyncModeProvider value>, but that seems a bit unusual.
talldan
commented
Sep 3, 2021
| @@ -94,7 +95,8 @@ export default function ListViewBranch( props ) { | |||
| }; | |||
|
|
|||
| return ( | |||
| <Fragment key={ clientId }> | |||
| // Make updates to the selected block synchronous. | |||
| <AsyncModeProvider key={ clientId } value={ ! isSelected }> | |||
There was a problem hiding this comment.
Could be further enhanced using an IntersectionObserver.
|
I noticed that in Safari, selecting blocks in the list view doesn't actually update the selected block there until you do another change in the UI (move focus or something else). I know that That said, it doesn't seem specific to this PR. |
gwwar
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Clever use of sync rendering of selected branches ✨ I couldn't think of ways of breaking this (copy, paste, cut works for me), but I did want to note that depending on the drag implementation it is possible to modify the list without having items selected.
Maybe see if we can get a +1 review here, or potentially enable a typing performance test with the list view open.
Here's an example of what I see on this branch:
CleanShot.2021-09-08.at.12.41.56.mp4
Good spot on the Safari behavior @youknowriad. I added #34669 to note the issues in trunk. Are you still seeing update issues on this branch for Safari, this branch appears to clear it up for me: CleanShot.2021-09-08.at.14.20.25.mp4 |
talldan
force-pushed
the
fix/list-view-slow-updates
branch
from
f39549a
to
d17c44f
Compare
|
@gwwar I think I've solved the problem with dragging. The issue seemed to be that each block was doing its own check to determine whether it or a parent was being dragged (and using an expensive I also did a little bit of other refactoring to reduce prop drilling and move selectedClientIds and draggedClientIds to the context provider. |
gwwar
reviewed
Sep 15, 2021
| } | ||
|
|
||
| return { | ||
| selectedClientIds: getSelectedBlockClientId(), |
There was a problem hiding this comment.
For other reviewers getSelectedBlockClientIds vs getSelectedBlockClientId
gwwar
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Nice work @talldan ! I tested this and verified that I'm no longer seeing artifacts on delete/paste/drag. I think the simplification of not rendering a dragged branch makes a lot of sense. Here's what I see:
CleanShot.2021-09-15.at.14.17.34.mp4
This was referenced Sep 16, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tries the suggestion in this comment to solve the slow updates in List View - #34477 (comment).
The problem seems to be that the main selector used to build the ListViewTree is wrapped in
<AsyncModeProvider value={ true }>. This PR moves the AsyncModeProvider into an inner part of the ListView component so that this is no longer the case. Each block and its nested block is also wrapped in a<AsyncModeProvider>with the select block being synchronous and unselected blocks being asynchronous.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).