Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: Home link option causes spacing issues #34470

Closed
2 tasks done
annezazu opened this issue Sep 1, 2021 · 3 comments
Closed
2 tasks done

Navigation block: Home link option causes spacing issues #34470

annezazu opened this issue Sep 1, 2021 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 1, 2021

Description

When adding the Home link option to the navigation block, the next item added causes spacing issues. This is likely related to #33021. This was found as part of the ninth call for testing for the FSE Outreach Program

Step-by-step reproduction instructions

  1. Add a navigation block.
  2. Add in the Home Link option.
  3. Add a custom link or an additional item and notice the spacing collapses.

Screenshots, screen recording, code snippet

spacing.home.mov

Environment info

  • WordPress 5.8
  • Gutenberg 11.4
  • TT1 Blocks
  • Desktop MacOS

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Sep 1, 2021
@annezazu
Copy link
Contributor Author

annezazu commented Sep 1, 2021

cc @jasmussen

@jasmussen
Copy link
Contributor

Thanks for the issue. I can't reproduce in trunk:

tt1

Furthermore, I'm almost certain that this issue has been fixed by #33918 and #33918, which together closed #33048. The motivation is best explained in this comment, but boiled down to each navigation item having its own navigation margin and padding styles, causing the exact issue described here.

Are you able to test using trunk?

@annezazu
Copy link
Contributor Author

annezazu commented Sep 2, 2021

Thanks as always for your lovely follow up. Confirmed that I can't replicate with trunk! Strange considering the PRs listed merged are shown for 11.4 (which I can replicate with). Closing this out either way.

@annezazu annezazu closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants