Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: use generic css class names for navigation items #33048

Closed
gwwar opened this issue Jun 28, 2021 · 0 comments · Fixed by #33918
Closed

Navigation: use generic css class names for navigation items #33048

gwwar opened this issue Jun 28, 2021 · 0 comments · Fixed by #33918
Assignees
@tellthemachines
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress

Comments

@gwwar
Copy link
Contributor

gwwar commented Jun 28, 2021

Children of the Navigation Block currently duplicate many CSS rules. This includes the Page List, Navigation Links, Home Link and potentially others.

Instead of duplicating CSS rules, let's add other CSS classes outside of the wp-block-name to provide consistent styling.

We should also be careful that Navigation style and color settings are propagated correctly, and that global and theme styling is handled appropriately.

See related #31879 and conversation in #32677
@gwwar gwwar added the [Block] Navigation Affects the Navigation Block label Jun 28, 2021
@gwwar gwwar mentioned this issue Jun 28, 2021
Closed
@tellthemachines tellthemachines mentioned this issue Jul 12, 2021
Closed
7 tasks
This was referenced Aug 2, 2021
Merged
Merged
Merged
@tellthemachines tellthemachines self-assigned this Aug 6, 2021
@tellthemachines tellthemachines mentioned this issue Aug 6, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 6, 2021
@jasmussen jasmussen mentioned this issue Sep 2, 2021
Closed
2 tasks
This was referenced Mar 30, 2022
Open
Open
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Sep 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tellthemachines tellthemachines

Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add generic classnames to children of Navigation WordPress/gutenberg
2 participants
@gwwar @tellthemachines