Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Site Title and Logo inside Navigation block. #33316

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

tellthemachines
Copy link
Contributor

Description

Partially addresses #33278. Allows Site Title and Site Logo blocks to be used inside a Navigation block.

How has this been tested?

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Size Change: +6.79 kB (+1%)

Total Size: 1.04 MB

Filename Size Change
build/block-directory/index.min.js 6.2 kB -4 B (0%)
build/block-editor/index.min.js 118 kB -440 B (0%)
build/block-editor/style-rtl.css 13.8 kB -19 B (0%)
build/block-editor/style.css 13.8 kB -23 B (0%)
build/block-library/blocks/gallery/editor-rtl.css 879 B +172 B (+24%) 🚨
build/block-library/blocks/gallery/editor.css 876 B +170 B (+24%) 🚨
build/block-library/blocks/gallery/style-rtl.css 1.7 kB +644 B (+61%) 🆘
build/block-library/blocks/gallery/style.css 1.7 kB +641 B (+61%) 🆘
build/block-library/blocks/group/theme-rtl.css 70 B -23 B (-25%) 🎉
build/block-library/blocks/group/theme.css 70 B -23 B (-25%) 🎉
build/block-library/blocks/navigation/style-rtl.css 1.67 kB +20 B (+1%)
build/block-library/blocks/navigation/style.css 1.66 kB +20 B (+1%)
build/block-library/editor-rtl.css 9.95 kB +80 B (+1%)
build/block-library/editor.css 9.93 kB +82 B (+1%)
build/block-library/index.min.js 150 kB +3.61 kB (+2%)
build/block-library/style-rtl.css 10.9 kB +704 B (+7%) 🔍
build/block-library/style.css 11 kB +711 B (+7%) 🔍
build/block-library/theme-rtl.css 658 B -30 B (-4%)
build/block-library/theme.css 663 B -29 B (-4%)
build/blocks/index.min.js 47 kB +62 B (0%)
build/components/index.min.js 209 kB -43 B (0%)
build/components/style-rtl.css 15.7 kB +1 B (0%)
build/compose/index.min.js 10.1 kB -33 B (0%)
build/customize-widgets/index.min.js 11.1 kB +709 B (+7%) 🔍
build/data/index.min.js 7.1 kB +26 B (0%)
build/edit-navigation/index.min.js 13.6 kB -58 B (0%)
build/edit-navigation/style-rtl.css 3.15 kB -46 B (-1%)
build/edit-navigation/style.css 3.14 kB -49 B (-2%)
build/edit-post/index.min.js 28.8 kB +153 B (+1%)
build/edit-post/style-rtl.css 7.2 kB -26 B (0%)
build/edit-post/style.css 7.2 kB -25 B (0%)
build/edit-site/index.min.js 26.2 kB +52 B (0%)
build/edit-widgets/index.min.js 16 kB -2 B (0%)
build/editor/index.min.js 37.7 kB +140 B (0%)
build/editor/style-rtl.css 3.74 kB -183 B (-5%)
build/editor/style.css 3.73 kB -181 B (-5%)
build/element/index.min.js 3.17 kB +7 B (0%)
build/rich-text/index.min.js 10.6 kB +7 B (0%)
build/widgets/style-rtl.css 1.05 kB +7 B (+1%)
build/widgets/style.css 1.05 kB +8 B (+1%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 931 B
build/admin-manifest/index.min.js 1.09 kB
build/annotations/index.min.js 2.7 kB
build/api-fetch/index.min.js 2.19 kB
build/autop/index.min.js 2.08 kB
build/blob/index.min.js 459 B
build/block-directory/style-rtl.css 1.01 kB
build/block-directory/style.css 1.01 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 111 B
build/block-library/blocks/audio/style.css 111 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 474 B
build/block-library/blocks/button/editor.css 474 B
build/block-library/blocks/button/style-rtl.css 605 B
build/block-library/blocks/button/style.css 604 B
build/block-library/blocks/buttons/editor-rtl.css 315 B
build/block-library/blocks/buttons/editor.css 315 B
build/block-library/blocks/buttons/style-rtl.css 370 B
build/block-library/blocks/buttons/style.css 370 B
build/block-library/blocks/calendar/style-rtl.css 207 B
build/block-library/blocks/calendar/style.css 207 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 194 B
build/block-library/blocks/columns/editor.css 193 B
build/block-library/blocks/columns/style-rtl.css 474 B
build/block-library/blocks/columns/style.css 475 B
build/block-library/blocks/cover/editor-rtl.css 666 B
build/block-library/blocks/cover/editor.css 670 B
build/block-library/blocks/cover/style-rtl.css 1.23 kB
build/block-library/blocks/cover/style.css 1.23 kB
build/block-library/blocks/embed/editor-rtl.css 488 B
build/block-library/blocks/embed/editor.css 488 B
build/block-library/blocks/embed/style-rtl.css 400 B
build/block-library/blocks/embed/style.css 400 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 322 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 159 B
build/block-library/blocks/group/editor.css 159 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/heading/editor-rtl.css 152 B
build/block-library/blocks/heading/editor.css 152 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 283 B
build/block-library/blocks/html/editor.css 284 B
build/block-library/blocks/image/editor-rtl.css 728 B
build/block-library/blocks/image/editor.css 728 B
build/block-library/blocks/image/style-rtl.css 482 B
build/block-library/blocks/image/style.css 487 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 284 B
build/block-library/blocks/latest-comments/style.css 284 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 528 B
build/block-library/blocks/latest-posts/style.css 527 B
build/block-library/blocks/list/style-rtl.css 63 B
build/block-library/blocks/list/style.css 63 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 488 B
build/block-library/blocks/media-text/style.css 485 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 474 B
build/block-library/blocks/navigation-link/editor.css 474 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation/editor-rtl.css 1.69 kB
build/block-library/blocks/navigation/editor.css 1.69 kB
build/block-library/blocks/navigation/view.min.js 2.52 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 310 B
build/block-library/blocks/page-list/editor.css 310 B
build/block-library/blocks/page-list/style-rtl.css 242 B
build/block-library/blocks/page-list/style.css 242 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 248 B
build/block-library/blocks/paragraph/style.css 248 B
build/block-library/blocks/post-author/editor-rtl.css 210 B
build/block-library/blocks/post-author/editor.css 210 B
build/block-library/blocks/post-author/style-rtl.css 182 B
build/block-library/blocks/post-author/style.css 181 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B
build/block-library/blocks/post-comments-form/style.css 140 B
build/block-library/blocks/post-comments/style-rtl.css 360 B
build/block-library/blocks/post-comments/style.css 359 B
build/block-library/blocks/post-content/editor-rtl.css 138 B
build/block-library/blocks/post-content/editor.css 138 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 398 B
build/block-library/blocks/post-featured-image/editor.css 398 B
build/block-library/blocks/post-featured-image/style-rtl.css 143 B
build/block-library/blocks/post-featured-image/style.css 143 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 378 B
build/block-library/blocks/post-template/style.css 379 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 361 B
build/block-library/blocks/pullquote/style.css 360 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B
build/block-library/blocks/query-pagination/editor.css 262 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B
build/block-library/blocks/query-pagination/style.css 168 B
build/block-library/blocks/query-title/editor-rtl.css 85 B
build/block-library/blocks/query-title/editor.css 85 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 169 B
build/block-library/blocks/quote/style.css 169 B
build/block-library/blocks/quote/theme-rtl.css 220 B
build/block-library/blocks/quote/theme.css 222 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 374 B
build/block-library/blocks/search/style.css 375 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 250 B
build/block-library/blocks/separator/style.css 250 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 474 B
build/block-library/blocks/shortcode/editor.css 474 B
build/block-library/blocks/site-logo/editor-rtl.css 462 B
build/block-library/blocks/site-logo/editor.css 464 B
build/block-library/blocks/site-logo/style-rtl.css 153 B
build/block-library/blocks/site-logo/style.css 153 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 84 B
build/block-library/blocks/site-title/editor.css 84 B
build/block-library/blocks/social-link/editor-rtl.css 165 B
build/block-library/blocks/social-link/editor.css 165 B
build/block-library/blocks/social-links/editor-rtl.css 812 B
build/block-library/blocks/social-links/editor.css 811 B
build/block-library/blocks/social-links/style-rtl.css 1.33 kB
build/block-library/blocks/social-links/style.css 1.33 kB
build/block-library/blocks/spacer/editor-rtl.css 307 B
build/block-library/blocks/spacer/editor.css 307 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 471 B
build/block-library/blocks/table/editor.css 472 B
build/block-library/blocks/table/style-rtl.css 481 B
build/block-library/blocks/table/style.css 481 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 636 B
build/block-library/blocks/template-part/editor.css 635 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/editor-rtl.css 90 B
build/block-library/blocks/term-description/editor.css 90 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 571 B
build/block-library/blocks/video/editor.css 572 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 1.29 kB
build/block-library/common.css 1.29 kB
build/block-library/reset-rtl.css 527 B
build/block-library/reset.css 527 B
build/block-serialization-default-parser/index.min.js 1.09 kB
build/block-serialization-spec-parser/index.min.js 2.79 kB
build/components/style.css 15.8 kB
build/core-data/index.min.js 12.3 kB
build/customize-widgets/style-rtl.css 1.5 kB
build/customize-widgets/style.css 1.49 kB
build/data-controls/index.min.js 614 B
build/date/index.min.js 31.5 kB
build/deprecated/index.min.js 428 B
build/dom-ready/index.min.js 304 B
build/dom/index.min.js 4.53 kB
build/edit-post/classic-rtl.css 492 B
build/edit-post/classic.css 494 B
build/edit-site/style-rtl.css 5.07 kB
build/edit-site/style.css 5.07 kB
build/edit-widgets/style-rtl.css 4.06 kB
build/edit-widgets/style.css 4.06 kB
build/escape-html/index.min.js 517 B
build/format-library/index.min.js 5.36 kB
build/format-library/style-rtl.css 668 B
build/format-library/style.css 669 B
build/hooks/index.min.js 1.55 kB
build/html-entities/index.min.js 424 B
build/i18n/index.min.js 3.59 kB
build/is-shallow-equal/index.min.js 501 B
build/keyboard-shortcuts/index.min.js 1.49 kB
build/keycodes/index.min.js 1.25 kB
build/list-reusable-blocks/index.min.js 1.85 kB
build/list-reusable-blocks/style-rtl.css 838 B
build/list-reusable-blocks/style.css 838 B
build/media-utils/index.min.js 2.88 kB
build/notices/index.min.js 845 B
build/nux/index.min.js 2.03 kB
build/nux/style-rtl.css 747 B
build/nux/style.css 743 B
build/plugins/index.min.js 1.83 kB
build/primitives/index.min.js 921 B
build/priority-queue/index.min.js 582 B
build/react-i18n/index.min.js 671 B
build/redux-routine/index.min.js 2.63 kB
build/reusable-blocks/index.min.js 2.28 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/server-side-render/index.min.js 1.32 kB
build/shortcode/index.min.js 1.48 kB
build/token-list/index.min.js 562 B
build/url/index.min.js 1.72 kB
build/viewport/index.min.js 1.02 kB
build/warning/index.min.js 248 B
build/widgets/index.min.js 6.27 kB
build/wordcount/index.min.js 1.04 kB

compressed-size-action

@jasmussen
Copy link
Contributor

This is really, really nice:

nav items

The above is a really basic navigation pattern that I think will be popular — Site Title would work well there also.

I used space-between to accomplish it, and realized that there's some margin work to do (or better yet, move to using gap, #32367), and I pushed a small space-between fix that appears to have regressed in trunk as well (happy to push it separately there as well, if need be). But both those are in the category of "trivial", and the important part is that the idea of allowing these two blocks feels very validated by this PR. Very nice work, thank you.

@jasmussen
Copy link
Contributor

I like this PR a lot, and it's very simple and neat. Revisiting it now, the primary thing stands out to me is the lack of margin:

Screenshot 2021-08-04 at 10 02 10

Screenshot 2021-08-04 at 10 02 34

The navigation block has CSS baked in that applies default margins to menu items inside. This:

.wp-block-page-list, .wp-block-page-list > .wp-block-pages-list__item, .wp-block-navigation__container > .wp-block-navigation-link {
    margin: 0 2em 0 0;
}

While we could duplicate that CSS or expand it to also target this block, the problem is that there are many compounding edgecases for those margins making it non trivial to duplicate, and at very high risk of drifting:

  • The margin is smaller if the navigation block has a background (which gives menu items padding instead)
  • The margin is different for items in dropdowns
  • The margin is different for items in the hamburger menu
  • The margin is different for the vertical navigation item

The CSS is already fairly gnarly, and this exact problem already affects the Home link item:

Screenshot 2021-08-04 at 10 06 08

The current best suggestion for how to address this is #33048, which is to add more generic "menu item" CSS classes that can be targeted by the margin and positioning rules, so that we don't have to duplicate and expand the complexity for every new menu item added.

I wouldn't necessarily object to this PR landing as-is, without addressing #33048 first. But it does seem slighly more urgently in need of being addressed. I'd love to pair with someone on fixing that, if anyone has bandwidth.

@tellthemachines
Copy link
Contributor Author

I wouldn't necessarily object to this PR landing as-is, without addressing #33048 first. But it does seem slighly more urgently in need of being addressed. I'd love to pair with someone on fixing that, if anyone has bandwidth.

As commented here, I'm happy to work on it as the problem does need to be addressed soon. The changes themselves should be straightforward, once we agree on the classnames.

@tellthemachines
Copy link
Contributor Author

@jasmussen with #33918 merged, what's the best way forward here? Should Site Title and Logo conditionally display the wp-block-navigation-item classname when they are inside the Nav block?

If so, I'm thinking we should have the CSS cleaned up and using the new classnames before we do that, so it's easier to test how it works.

@jasmussen
Copy link
Contributor

Should Site Title and Logo conditionally display the wp-block-navigation-item classname when they are inside the Nav block?

In my dream scenario, the navigation block itself would apply classnames to its children based on their location inside. Would that be possible at all?

If so, I'm thinking we should have the CSS cleaned up and using the new classnames before we do that, so it's easier to test how it works.

I'm spread across a few separate projects at the moment, but I will get to the CSS cleanup as soon as possible! Very excited about it, thanks again.

@tellthemachines
Copy link
Contributor Author

In my dream scenario, the navigation block itself would apply classnames to its children based on their location inside. Would that be possible at all?

It's possible to set classnames conditional on position via block attributes, but I need to look into what happens when the blocks are moved around inside navigation. For this to work, the parent block will need to be aware of changes in order of its inner blocks.

What classnames would you like to apply to which locations?

@jasmussen
Copy link
Contributor

What classnames would you like to apply to which locations?

It's mostly a philosophy that the layout of child elements should be handled by the container if possible. In this case, due to the fact that we allow a variety of elements inside the navigation block (and that it can vary from editor to frontend), ideally we could just have a single generic CSS class that indicates: this is now a menu item. So it could be the same CSS class as you applied in that separate classname PR.

What do you think?

@tellthemachines
Copy link
Contributor Author

It's mostly a philosophy that the layout of child elements should be handled by the container if possible.

How is this being handled in other cases? I know there was some work done recently on the Group block; have there been any thoughts around adding classnames to child blocks? If so it would be best to try for a solution that works everywhere.

Either way, I'm wondering if the context solution @getdave and I were discussing on the generic classnames PR might be a good fit. If it turns out that Site Title and Logo might need different custom classnames when they are children of some other block, passing a classname though context is a good solution. Even if they only need a classname when they're inside Navigation, we'll have to leverage some form of context to know when the blocks are inside Navigation.

(None of that should change the work done in the previous PR though: Page List needs classnames added in several places in its markup, which would be unwieldy to pass through context.)

@jasmussen
Copy link
Contributor

How is this being handled in other cases? I know there was some work done recently on the Group block; have there been any thoughts around adding classnames to child blocks? If so it would be best to try for a solution that works everywhere.

No, I think adding child classes is a bit of an edgecase for the navigation block due to its complex layout and structure. I was thinking most in terms of layout and such, where the gap property can be assigned to the container, and thereby affecting the layout of child items directly.

@tellthemachines
Copy link
Contributor Author

@jasmussen I've updated this PR to add the wp-block-navigation-item classname to the li that wrap the site title and logo blocks. They are only added on the server side though, so we may still need some adjustment to styles in the editor. Once both this PR and your CSS one are merged, we can see how they work together and determine if anything else is needed.

I guess this is now ready for a final review!

@jasmussen
Copy link
Contributor

Wonderful. I landed the CSS refactor (thanks again for the reviews), so a rebase on this one might unlock things.

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tellthemachines tellthemachines merged commit 7a6c1f2 into trunk Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Site Logo Affects the Site Logo Block [Block] Site Title Affects the Site Title Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants