Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core themes throwing stylesheet was not properly added error. #35018

Closed
gwwar opened this issue Sep 21, 2021 · 4 comments
Closed

Core themes throwing stylesheet was not properly added error. #35018

gwwar opened this issue Sep 21, 2021 · 4 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@gwwar
Copy link
Contributor

gwwar commented Sep 21, 2021

Description

I'm not sure if this is expected behavior, but when inserting certain types of blocks we can see a "stylesheet was not properly added error" in console.

Edit: So chatting with folks we do still support these themes, the console error is more of a warning to use a newer path.

Let's change the console.error to console.warn to make this less scary (deprecations typically show up as warnings vs error).

Step-by-step reproduction instructions

  1. Use one of the following themes (twentyten, twentyeleven, twentytwelve, twentythirteen, twentyfourteen, twentyfifteen, twentysixteen, twentyseventeen, and twentytwenty)
  2. Add a block that has a styles block setting panel (image block, site-logo, social-links etc)
  3. Make sure the sidebar is open and select the block
    Expected: no js errors thrown
    Actual:

CleanShot 2021-09-21 at 11 10 58@2x

Screenshots, screen recording, code snippet

CleanShot.2021-09-21.at.10.55.38.mp4

Environment info

Gutenberg trunk / wp-develop master

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@gwwar gwwar added the [Type] Bug An existing feature does not function as intended label Sep 21, 2021
@gwwar
Copy link
Contributor Author

gwwar commented Sep 21, 2021

Going to refile this in trac since we'll need theme updates

@gwwar gwwar closed this as completed Sep 21, 2021
@gwwar
Copy link
Contributor Author

gwwar commented Sep 21, 2021

@gwwar gwwar reopened this Sep 22, 2021
@gwwar
Copy link
Contributor Author

gwwar commented Sep 22, 2021

So chatting with folks we do still support these themes, the console error is more of a warning to use a newer path.

With that in mind I'll update the issue to change the console.error to console.warn to make this less scary (deprecations typically show up as warnings vs error).

@gwwar gwwar added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Sep 22, 2021
@oandregal
Copy link
Member

errors have been transformed into warnings at #35914 so I presume we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants