Change console.error to console.warn for enqueued styles in the editor
#35914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -33 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
aristath
force-pushed
the
fix/console-error-to-warn
branch
from
335b734 to
74bd071
Compare
aristath
requested review from
ajitbohra,
ellatrix,
nerrad and
ntwb
as code owners
aristath
changed the title
console.error to console.warn for enqueued styles in the editor
ntsekouras
approved these changes
Oct 25, 2021
packages/e2e-tests/specs/editor/plugins/iframed-multiple-block-stylesheets.test.js
Outdated
Show resolved
Hide resolved
…-stylesheets.test.js Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
vcanales
pushed a commit
that referenced
this pull request
Oct 27, 2021
…ditor (#35914) * Change console.error to console.warn * Remove no longer valid expect( console ).toHaveErrored() tests * Change checks to toHaveWarned * Update packages/e2e-tests/specs/editor/plugins/iframed-multiple-block-stylesheets.test.js Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are multiple issues in the repo because of an error the console prints - introduced in #31870.
The problem is that these should never have been errors, they should be warnings since they are about a deprecation and nothing actually breaks.
Additionally, the code in #31870 doesn't take into account all valid scenarios and causes a lot of confusion.
The errors assume that if a stylesheet gets added to the editor, it's either a theme style (in which case it should use
add_editor_style, or a block style (in which case the stylesheet should be defined in the block'sblock.jsonfile).But there are many more cases that are valid... Currently, plugins can't add styles without adding a block - and in many cases, they need to.
Types of changes
Changed
console.errortoconsole.warn.Checklist:
*.native.jsfiles for terms that need renaming or removal).