Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of "supports" panels #35541

Closed
Tracked by #33447
mtias opened this issue Oct 12, 2021 · 7 comments
Closed
Tracked by #33447

Order of "supports" panels #35541

mtias opened this issue Oct 12, 2021 · 7 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Oct 12, 2021

Right now the order of panels is not reflective of their importance, particularly border being so prominent. Let's revise it towards:

  • Layout
  • Color
  • Typography
  • Dimensions
  • Border
  • Advanced
@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Oct 12, 2021
@mtias mtias mentioned this issue Oct 12, 2021
65 tasks
@ramonjd ramonjd self-assigned this Oct 12, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 13, 2021
@ramonjd
Copy link
Member

ramonjd commented Oct 13, 2021

I've swapped the styles supports order for now in #35574

The Dimensions Inspector Controls group is, however, rendered as the next to last Slot, before the Advanced controls, so it'll always render in that position.

I think we need to pick up on @gziolo's idea in #34069 to achieve more control over the order of Inspector Control slots.

Now, there is a question about what we do about Global Styles UI. If that should be a single group or we should have more groups, for example:

  • default
  • layout
  • typography
  • border
  • color
  • dimensions

I'll get stuck into that straight away, but also cc @aaronrobertshaw for a confidence check on this opinion first :)

@ramonjd
Copy link
Member

ramonjd commented Oct 13, 2021

I'll get stuck into that straight away, but also cc @aaronrobertshaw for a confidence check on this opinion first :)

Answered here: #35574 (comment)

The grouped inspector controls slots will add a bit of a wrinkle to this as you mentioned. It might be handy to know that I'm creating these new inspector control groups as part of switching the block support panels to use the ToolsPanel.

These new groups/panels were being approached one at a time, typography, color, then border. I'm not sure there is a quicker or more efficient means of adopting the new groups/approach.

Obviously, this can be landed to get us one step closer if there is a hurry to improve it. Otherwise, we could address it incrementally, ensuring the panel switch PRs match the proposed order.

Thank you!

@aaronrobertshaw
Copy link
Contributor

The Dimensions Inspector Controls group is, however, rendered as the next to last Slot, before the Advanced controls, so it'll always render in that position.

The other block support panels will be switched to use new inspector control groups when they are updated to use the ToolsPanel.

At this point, I've only updated the typography panel PR. The color and border panel PRs will be updated in the next couple of days. As I do this, I'll make sure the panels are as close to the proposed order as possible.

I think we need to pick up on @gziolo's idea in #34069 to achieve more control over the order of Inspector Control slots.

I'm a little behind with regards to the Global Styles sidebar, I know it's been overhauled recently. With its new presentation is this ordering applicable or is it only for block supports?

@ramonjd
Copy link
Member

ramonjd commented Oct 13, 2021

I'm a little behind with regards to the Global Styles sidebar, I know it's been overhauled recently. With its new presentation is this ordering applicable or is it only for block supports?

That's a good question, thanks for reminding me. I had screenshots I prepared earlier to raise this, but... you know, forgot :)

Here's what I'm seeing in the Site Editor:

Screen Shot 2021-10-13 at 1 31 10 pm

Screen Shot 2021-10-13 at 1 32 02 pm

I'd assume the order would persist throughout the app?

@aaronrobertshaw
Copy link
Contributor

Yeah, so from those screenshots I'd take it that we won't be re-grouping all the panels, only swapping the positions of typography and layout from the first screenshot.

@mtias
Copy link
Member Author

mtias commented Oct 13, 2021

I'm a little behind with regards to the Global Styles sidebar, I know it's been overhauled recently. With its new presentation is this ordering applicable or is it only for block supports?

Only for block supports for now. In global styles, only the per-block categories would reflect that order. The root level will remain as the design above.

@apeatling apeatling moved this to In Progress in Design Tools Project Nov 2, 2021
@apeatling apeatling moved this from ⏳ In Progress to 🔺 Stale in Design Tools Project Nov 2, 2021
aaronrobertshaw added a commit that referenced this issue Dec 17, 2021
This is a step towards achieving the panel order as outlined in #35541
@aaronrobertshaw
Copy link
Contributor

With the color panel switching to using the ToolsPanel and the grouped InspectorControls slot, the order of the block support panels now match the order outlined in this issue. I'll close this as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
Status: Done
Development

No branches or pull requests

3 participants