Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: Add buttons block to the allowed blocks #35924

Closed
briceduclos opened this issue Oct 25, 2021 · 6 comments · Fixed by #53966
Closed

Navigation block: Add buttons block to the allowed blocks #35924

briceduclos opened this issue Oct 25, 2021 · 6 comments · Fixed by #53966
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@briceduclos
Copy link

What problem does this address?

The navigation block currently supports menu items (page, post, custom, tag, category, ...) links, Social Icons, Spacer, and Search blocks (#33278).

However, it’s currently not possible to add a button block while it’s a common feature to have a button inside the site’s header.

What is your proposed solution?

Allow the Buttons block inside the navigation block.

@lwangdu
Copy link

lwangdu commented Oct 25, 2021

I would love to have option to add a button on the navigation block to.

@carolinan carolinan added [Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement. labels Oct 26, 2021
@chthonic-ds
Copy link
Contributor

A big vote from me to allow a Buttons block as a child of the Navigation block. I just noticed this fairly common header/navigation pattern isn't currently possible:

35924-add-button-inside-navigation-block

@coreyworrell
Copy link
Contributor

This issue needs traction.. At the minimum we should be able to apply classes to the anchor tag. Then you could at least manually style as a button, the Link Advanced CSS Class could be set to wp-block-button and a new Anchor CSS Class field could then be set to wp-block-button__link has-primary-background-color has-background. But it's much harder to do at the moment.

@masperber
Copy link

+1 to this feature request. This is very commonly requested on .com

@csabarakasz
Copy link

+1 to this feature!

@huubl
Copy link
Contributor

huubl commented Aug 29, 2023

+1!

Related:
#46256
#31387

torounit added a commit that referenced this issue Sep 6, 2023
* add `core/buttons` to allowed blocks. ref #35924

* add transform to buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants