Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Make Blocks section more distinguishable #36569

Closed
kafleg opened this issue Nov 17, 2021 · 7 comments · Fixed by #37293
Closed

Global Styles: Make Blocks section more distinguishable #36569

kafleg opened this issue Nov 17, 2021 · 7 comments · Fixed by #37293
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@kafleg
Copy link
Member

kafleg commented Nov 17, 2021

What problem does this address?

At first please see this image,
image

In the style section of blocks, there is a text named Blocks but it is clickable and can open block list. But, it's not appearing like button or clickable things. It simply display like text. We can make it even better to make it like button.

What is your proposed solution?

We can simply make it like button to give the outline to that text.

@annezazu
Copy link
Contributor

Thanks for this idea! Rather than make it look like a button, I wonder if it would make more sense to give it an icon so it is similar to the other Global Styles options cc @kellychoffman. Going to add design feedback for now.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. labels Nov 19, 2021
@annezazu annezazu changed the title Make the Blocks link like button Global Styles: Make Blocks section more distinguishable Nov 19, 2021
@kafleg
Copy link
Member Author

kafleg commented Nov 19, 2021

That might be the best option!

@aristath
Copy link
Member

aristath commented Dec 9, 2021

@youknowriad should we do this in 5.9? It looks like an easy fix and a good enhancement... We'd just need a suitable icon 🤔

@youknowriad
Copy link
Contributor

I'll defer to designers for this, I just followed the design from the initial issue. cc @mtias @pablohoneyhoney @jasmussen

@mtias
Copy link
Member

mtias commented Dec 9, 2021

The full design is not yet implemented:

image

Note the chevron, proximity to the descriptive text, etc.

@youknowriad
Copy link
Contributor

@aristath I added to the 5.9 board, should be an easy one indeed.

@ramonjd
Copy link
Member

ramonjd commented Dec 13, 2021

It looks like an easy fix and a good enhancement... We'd just need a suitable icon

In case the full design (mentioned above) isn't ready or not implemented in time, I've added the default "block" icon as used in the BlockIcon component in this PR.

Screen Shot 2021-12-13 at 12 25 08 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants