Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color select component backdrop render and animation opportunities #37506

Closed
KevinBatdorf opened this issue Dec 18, 2021 · 4 comments · Fixed by #38008
Closed

Color select component backdrop render and animation opportunities #37506

KevinBatdorf opened this issue Dec 18, 2021 · 4 comments · Fixed by #38008
Assignees
@ciampo @KevinBatdorf
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@KevinBatdorf
Copy link
Contributor

Description

The rendering on the backdrop is inconsistent when rendering inside an animating parent. The current implementation has a delay of 100ms but it's not very reliable, and is also dependent on the parent animating for 100ms.

Step-by-step reproduction instructions

  1. Add a group block
  2. Open the color settings
  3. Press Background color
  4. Toggle gradient and solid items

Screenshots, screen recording, code snippet

Screen.Recording.2021-12-17.at.9.56.14.PM.mov

Environment info

  • Gutenberg 12.2.0-rc.1
  • TT1 Blocks
  • Chrome
  • Mac

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@KevinBatdorf KevinBatdorf mentioned this issue Dec 18, 2021
Closed
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 18, 2021
@mirka mirka added the [Package] Components /packages/components label Dec 21, 2021
@KevinBatdorf KevinBatdorf mentioned this issue Jan 15, 2022
Merged
8 tasks
@ciampo ciampo mentioned this issue Apr 4, 2022
Merged
@ciampo ciampo reopened this Apr 4, 2022
@ciampo
Copy link
Contributor

ciampo commented Apr 4, 2022 •
edited
Loading

Reopening — see details in #40021

@ciampo ciampo mentioned this issue Apr 6, 2022
Closed
@ciampo
Copy link
Contributor

ciampo commented Apr 6, 2022

Opened #40107 with new tentative fix

@ciampo ciampo mentioned this issue Apr 12, 2022
Closed
@ciampo
Copy link
Contributor

ciampo commented Apr 12, 2022

New approach with framer-motion's shared animation layout in #40276

@ciampo ciampo mentioned this issue May 3, 2023
Merged
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@stokesman
Copy link
Contributor

I believe this should have closed with #50278.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

@KevinBatdorf KevinBatdorf

Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
5 participants
@mirka @ciampo @KevinBatdorf @jordesign @stokesman