-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToggleGroupControl: Reintroduce backdrop animation #40021
Merged
ciampo
merged 3 commits into
trunk
from
feat/toggle-group-control-reintroduce-animated-backdrop
Apr 4, 2022
Merged
ToggleGroupControl: Reintroduce backdrop animation #40021
ciampo
merged 3 commits into
trunk
from
feat/toggle-group-control-reintroduce-animated-backdrop
Apr 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Bug
An existing feature does not function as intended
[Package] Components
/packages/components
[Feature] Component System
WordPress component system
labels
Apr 4, 2022
ciampo
changed the title
ToggleGroupControl: Reintroduce backdrop animation @ciampo
ToggleGroupControl: Reintroduce backdrop animation
Apr 4, 2022
ntsekouras
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Marco!
Size Change: +345 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ciampo
deleted the
feat/toggle-group-control-reintroduce-animated-backdrop
branch
April 4, 2022 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Package] Components
/packages/components
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Revert changes applied in #38008 in order to reintroduce the backdrop animation in
ToggleGroupControl
.Note: this PR will reintroduce the bug flagged in #37506
Why?
See #38008 (comment)
How?
Reverted all code changes from #38008
Testing Instructions