Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Group block to transform to the Row variation #39066

Closed
richtabor opened this issue Feb 24, 2022 · 4 comments · Fixed by #50139
Closed

Allow Group block to transform to the Row variation #39066

richtabor opened this issue Feb 24, 2022 · 4 comments · Fixed by #50139
Assignees
Labels
[Block] Group Affects the Group Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback.

Comments

@richtabor
Copy link
Member

What problem does this address?

While uncovering ways to improve the Group block editing experience, I found that transforming between the standard vertical-oriented Group block, to the Row variant, is still a bit convoluted.

This made be lean in to ask, should variation transforms be treated any differently than block transforms in the UI?

Is there a reason to not include the "Row" variant as an option in the typical transforms UI — instead of having a separate variation UI?

What is your proposed solution?

Consider allowing block variants within the transform UI, so that variants are more easily surfaced in existing UI patterns (instead of replying solely on a separate control to "Transform to variation".

The Group block's row variation omitted from primary transform interaction

CleanShot 2022-02-24 at 12 52 00@2x

Transform to variation UI (should this be treated differently than standard transforms?)

CleanShot 2022-02-24 at 12 53 25@2x

@richtabor richtabor added [Block] Group Affects the Group Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Feb 24, 2022
@skorasaurus skorasaurus added the Needs Design Feedback Needs general design feedback. label Feb 24, 2022
@skorasaurus
Copy link
Member

Thanks for continuing the conversation; @youknowriad mentions it at #36202 (comment)

@richtabor
Copy link
Member Author

Thanks for continuing the conversation; @youknowriad mentions it at #36202 (comment)

Yes, that exactly!

@jasmussen
Copy link
Contributor

Good ticket. There's a potentially largish design exploration possible here.

The transforms interface — the dropdown you get by clicking the block icon — has huge potential, and can become the go-to destination to check when inserting a new block, or looking for layout changes or options on an existing block:

  • It could surface variations or alternate styles or layouts
  • It could surface different block or pattern transforms (with previews) that can accomplish an interesting layout didn't think of
  • It could potentially hold locking options (On Locking and TemplateLocking #29864)

In addition to this, as is also discussed here, there are currently multiple different interfaces that all feel related to transforming blocks. It'd be good to look at unifying these.

Exploring a holistic vision for a lovely singular card with a full range of transforms could be a fun task with a big mockup and prototype. That's not to say it needs to block smaller iterations; but it would be a good north star to keep in mind!

@mtias
Copy link
Member

mtias commented Aug 19, 2022

We could also consider exposing these in the group block toolbar directly, like we do for multi-select:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants