-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforms: Quote should not be suggested as a transform from a Group #49879
Comments
That's odd, def shouldn't be the case.
Agreed. We currently don't have support for block variation transforms in this popover, though we should. Related: #49584 (comment) |
Even the Grid transform to the Cover block is odd. |
It is just a hangover from the fact that under the hood it is just a Group block, and the Group block has always had a transform to Cover, which makes sense for a standard Group. The transforms have an |
💯 if we're going to offer multiple transform methods, I'd say the prioritised transforms should appear in all locations. That means: variations should appear above the horizontal rule in the transforms menu. This would help with post meta blocks too. |
Let's roll with this, with a goal of having Quote not suggested for Groups (or its variations). |
What problem does this address?
While using the experimental Grid layout, I noticed that the transform menu prioritizes transforming to a Quote block:
It turns out the same thing happens with the Stack block:
Semi related: #49524 and #39066
What is your proposed solution?
At the least, update the transforms to show something more relevant like Columns rather than quote. Ideally, I'd like to see the transforms show the variations in full (stack, row, group, grid).
@WordPress/gutenberg-design since there wasn't consensus reached on this prior issue that reflected how the transforms menu needs to be thought of in a larger way. While I believe that to be true, I also think we need to make some changes to the Group block variations sooner rather than later with so many variations built in now.
The text was updated successfully, but these errors were encountered: