Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography size setting in Paragraph and Heading block has no undo functionality. #39283

Closed
Smit2808 opened this issue Mar 8, 2022 · 5 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed

Comments

@Smit2808
Copy link
Contributor

Smit2808 commented Mar 8, 2022

Description

When typography size setting is used in paragraph and heading block. Then after giving some size like 1 or 2 then not able to set to default after selecting some size.

So the solution is after selecting some size by clicking on it, when want to undo it or set to default size again then by clicking the selected size again then it should be set it to the default size.

Step-by-step reproduction instructions

  1. Add heading/paragraph block.
  2. Set the Typography size from block settings.
  3. Now want to set it to the default size, but not able to set it to the default size.

Attaching video link for better understanding.

Screenshots, screen recording, code snippet

video link: https://www.loom.com/share/620ca5f78a604942b87ea8f921a060cc

Environment info

-> Wp version 5.9.1
-> Fresh WordPress site, not having any external plugin or theme.
-> Gutenberg cloned from the Github repo trunk branch.
-> Browser chrome.
-> Mac os.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. labels Mar 9, 2022
@talldan
Copy link
Contributor

talldan commented Mar 9, 2022

I see what you mean. There is a 'Reset all' button here in the dropdown menu:
Screen Shot 2022-03-09 at 11 29 14 am

But that will reset all typography settings. If you just want to deselect a size, that doesn't seem possible in the UI.

edit: It is also possible to click here and empty out the custom font size field that appears:
Screen Shot 2022-03-09 at 11 31 40 am

@Smit2808
Copy link
Contributor Author

Smit2808 commented Mar 9, 2022

Hi @talldan, yes I know that we can undo the size by using "set custom size" settings. But for the user who is not familiar with the "set custom size" setting, then it will be harder for the user. And user will always try to undo the font size by clicking that selected font again. So I think this undo setting we should add this undo setting, from a UI/UX point of view it is very important.

I am working on a patch for this. I am a wp core and meta contributor but I am new to Gutenberg contribution, so any help will be appreciated.

thank you.

@talldan
Copy link
Contributor

talldan commented Mar 11, 2022

I agree with your points, I was just adding some extra detail to the issue and sharing possible workarounds for anyone that may be reading.

Thanks for volunteering to contribute. Let me know if you need any help with the contribution process for Gutenberg.

I think it would be good to get input from a designer on this issue, so an option might be to reach out in the #design channel in the WordPress slack.

@cbirdsong
Copy link

cbirdsong commented Mar 21, 2022

FYI, there is already discussion of this very confusing design here: #38219

It's worth noting that if you register more than five font sizes then the control reverts to a <select>-style design and this problem goes away entirely:
CleanShot 2022-03-21 at 08 51 05

@talldan
Copy link
Contributor

talldan commented Mar 28, 2022

Thanks for pointing that out @cbirdsong. This issue looks like a duplicate of #38219, so I'll close it.

@talldan talldan closed this as completed Mar 28, 2022
@talldan talldan added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed Needs Design Feedback Needs general design feedback. labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed
Projects
None yet
Development

No branches or pull requests

3 participants