-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend theme.json to provide spacing size presets #39371
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@cbirdsong, @mrwweb, @eric-michel, @bradley2083, @richtabor - just pinging a few people that have commented on various spacing presets related issues - apologies if I missed someone, please feel free to comment about the below if you weren't pinged. With the code freeze for 6.1 features coming up next week we are at a point where we probably won't get any additional spacing preset features added in time to make it into 6.1, so it is probably a good point to check what we currently have, and that it is fully featured and stable enough for going into Core WP 6.1. The current state is: ✅ Spacing presets can be added to theme.json either as a calculated scale or as a manual fixed array of sizes Would be good to hear if you think there is anything critical missing still in your view that would prevent this from being feature complete enough to go into Core. One aspect of the current implementation that would be good to review is the way that presets from the Core --wp--preset--spacing--20: 0.44rem;
--wp--preset--spacing--30: 0.67rem;
--wp--preset--spacing--40: 1rem;
--wp--preset--spacing--50: 1.5rem;
--wp--preset--spacing--60: 2.25rem;
--wp--preset--spacing--70: 3.38rem;
--wp--preset--spacing--80: 5.06rem;
--wp--preset--spacing--45: 1.40rem ... but, in the Editor UI, only the single "Smallish" size appears for selection, the theme presets list overwrites the Core ones rather than extending them at this point. This code for the spacing presets largely mirrored the font sizes code which behaves the same way. It appears that the intention was that any theme wanting to add different fonts would include all of the fonts they wanted in the Does it make sense from a theme/plugin author's point of view that spacing preset sizes behaves the same way as font size presets, ie. adding a We could also merge the values for the UI, but then it would diverge from the font sizes behaviour so may cause confusion. Something to note is that the discussion around the slugs, and the decision to go with the format of I still think there is value in this slug format, eg. a theme might add a much wider static scale than Core, and doing so in say a Just to clarify, we don't currently have the functionality to find fallback values, this will be a 6.2 feature at this point 🤞 |
@glendaviesnz Thanks for all of your work on this! From what you're saying, I would say from a theme author point of view, these features seem extensive and stable enough to push to 6.1. One question I have on the current spacing presets and I assume it's possible, but can we change the label for spacing from "2X-Small", "X-Small", "Small", etc. to something custom e.g. "10", "20", "30"? And I know I'm repeating myself here, but I do think mobile spacing has to be a top priority in 6.2 if it won't make 6.1. Something so the site author can adjust spacing on mobile like: |
There's a separate goal outlined in #43412 of replacing those with 1x, 2x, 3x, etc. |
@glendaviesnz thank you so much for dedicating so much time to getting this ready for 6.1!
I'm currently working on a 200+ page site for one of our larger clients, and have fully transitioned our parent theme to adopt I'd say it's absolutely ready for a 6.1 deployment in its current state. I'm finding the controls very intuitive to use, and though our content editors have not gotten their hands on the site yet, I'm sure they will find it easier to use than utility classes. There's one usability request I have (which is definitely not needed before 6.1, but could theoretically be done pretty quickly if others agree): right now, the padding control links all 4 sides, and when unlinked, makes all 4 sides independent. We very rarely use left/right padding, but use top/bottom padding all the time, and having to unlink the 4 sides then select padding values for both top and bottom separately feels cumbersome compared to my old method of adding a utility class like I would love to see one of two options:
My preference would be number 2 since that's how we build sites (in the rare circumstance that we want all 4 sides to have the same padding, we'll just set both sliders to the same value), but I also realize that there might be tons of people commonly use padding equally on all 4 sides. I'd be curious what others on this board think. edit: I guess in a perfect world, these could be options set in
I tend to prefer consistent behavior whenever possible, so I'd say yes. Merging the values could also result in some pretty weird outcomes, depending on the scale that the theme creator uses for their spacing presets. |
It would be great if the spacer block could be converted to use it in time since that's the only other core block that uses custom sizes of this type, but I'm guessing the timing is too tight? |
@bradley2083 you can set these to whatever you want by adding a Instead of a specific mobile setting would it work if there was the option to add fluid values in the interfaces that compile down to a @cbirdsong I have a draft PR up for adding spacing presets to the Spacer block, but there are a couple of complications, so not sure if we will get agreement and sign off on it before the 6.1 code freeze. One question is whether when @eric-michel I have added your idea about multi-side editing as a task on this tracking issue so it doesn't get forgotten. |
@glendaviesnz re: mobile |
@bradley2083 You can manually set |
Hello @glendaviesnz really useful dev note. I am one of the reviewers. Could you please check that an introductory text on the dev note, as below, would be in line with the solution on this issue please. An adaptation of this will also be used for the excerpt. Thank you. |
thanks, @abhansnuk, that looks good to me - FYI, I just made a couple of edits to the dev note as I noticed it was missing a couple of last-minute updates that were merged into 6.1. |
I just started testing out the new spacing presets and noticed the generated CSS in the frontend looks like this:
In the editor it works:
In my theme.json I have:
Am I doing something wrong, am I missing something or is this a bug? The difference in the class numbers and the double assignment of them in the frontends CSS is kinda confusing. Is there a reason behind this? |
Thanks for reporting this @Azragh - I was not able to replicate the output you are seeing, what versions of Gutenberg and WP are you using? |
Actually @Azragh it looks like it might be caused by this bug which is resolved in 14.3 |
@glendaviesnz I'm using Gutenberg v14.2.0 and WordPress v6.0.2. Even without any plugins except Gutenberg I get this output. But I just tested with twentytwentytwo (made a child theme, defined variables in style.css, copied theme.json and added my spacing presets) and here it works.. I still get the classname assigned 2 times but the variable is defined. So it has to do something with my theme obviously.. Which bug do you mean? |
Sorry @Azragh, I forgot to add the link in the previous comment #44435 - 🤞 the fix here will resolve this for you. You could try the 14.3 release candidate to confirm that. |
@glendaviesnz Sorry for the late response - works as it should. 😁 |
Do we have a general consensus of how margin/padding are going to work in the future for different screen sizes? clamp() seems to work OK, but I think it would be better to have greater control of spacingSizes at different breakpoints. Maybe a minimum width or a range?
Given these spacing sizes, On mobile (<400px) I might want 20px of padding on something (X-Small) and Desktop (>=1024) I might want 100px of padding (X-Large). |
Removing from 6.4 -- still lots to design and figure out with only 4 weeks remaining ahead of 6.4 beta 1. |
I'd like to get more eyes on this, and font size presets. Theme designers (and users of their themes) should be able to configure all presets of a theme from Global Styles. |
There's currently a major issue with the way presets work inside the spacer block: #54084 |
I am hoping for an implementation that follows how fluid fontSizes are defined in theme.json, for example: "spacing": {
"fluid": true,
"spacingSizes": {
{
"name": "Example",
"slug": "example",
"size": "1rem",
"fluid": {
"min": "0.5rem",
"max": "1.5rem"
}
},
// ...
}
} |
What problem does this address?
Background discussion.
On the above issue, there was some consensus that there would be value in extending theme.json to allow spacing size presets to be added, which gives users a set of preset size tokens to select from as well as/or instead of just adding custom spacing values.
This blog post provides a good introduction to some of the reasons for this.
This is intended to be a top-level issue for some of the initial discussions, as well as tracking the ongoing work needed to implement this.
The block UI will need to allow people to select from the presets (e.g. padding value Medium) in addition to the "absolute value" settings (e.g typing "23px"), and also allow for theme authors to disable the option to add absolute values.
Update
Summary of discussion and suggested way forward
Todo
steps:0
Done
customSpacingSize
value fromtheme.json
to UI and disable custom sizing whenfalse
(Spacing presets: Implement disabling of custom space sizes #43216)(Mobile spacing issues #40486) are looked at as part of this
The text was updated successfully, but these errors were encountered: