Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing spacing presets for height of spacer block #43816

Closed
mikachan opened this issue Sep 2, 2022 · 7 comments
Closed

Consider providing spacing presets for height of spacer block #43816

mikachan opened this issue Sep 2, 2022 · 7 comments
Labels
[Block] Spacer Affects the Spacer Block [Type] Enhancement A suggestion for improvement.

Comments

@mikachan
Copy link
Member

mikachan commented Sep 2, 2022

What problem does this address?

When adding a spacer block, the height can currently only be set using the manual height control:

image

What is your proposed solution?

It would be nice if the height could also be set using any available spacing presets, similar to how margin, padding, and block gap settings now work:

image

Related PRs:
#42173
#43466
#43246

@richtabor
Copy link
Member

Agreed! No reason why it should adopt the same model imo.

@richtabor
Copy link
Member

@mikachan This looks to be a duplicate of #43815 — accident?

@mikachan
Copy link
Member Author

mikachan commented Sep 2, 2022

This looks to be a duplicate of #43815 — accident?

Ugh yes thanks, I think I hit a shortcut to save the issue before I was ready! 🙈

@bgardner
Copy link

bgardner commented Sep 2, 2022

Huge fan of this—great suggestion @mikachan!

@t-hamano t-hamano added the [Type] Enhancement A suggestion for improvement. label Sep 2, 2022
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Sep 3, 2022

Have added to the Spacing presets tracking issue.

image

@mikachan do you always see the white segment square displaying over the range control thumb? Does it disappear if you do a hard refresh? Seems to happen intermittently for some people so would be good to try and track down why sometimes the correct z-index is not applied.

@mikachan
Copy link
Member Author

mikachan commented Sep 5, 2022

Thanks for adding this to the tracking issue!

do you always see the white segment square displaying over the range control thumb? Does it disappear if you do a hard refresh?

Yes, it seems to have disappeared after a hard refresh (I've also just pulled the latest trunk, although I was only 6 commits behind).

image

I'm not sure if I've always seen it.. I'll keep my eye on it and see if it seems intermittent for me.

@mikachan
Copy link
Member Author

mikachan commented Apr 5, 2023

Closing this as #44002 should address it 🎉

@mikachan mikachan closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Spacer Affects the Spacer Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants