-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacing step variables not getting generated properly with Block Spacing #44435
Comments
@glendaviesnz @annezazu FYI. |
A quick update after additional testing. This appears related to the new layout settings on container blocks. If you set "Inner blocks use content width" on the Group block, everything then works. The Column block obviously does not have this layout setting, so the issue still exists there. I guess that there is some conditional restricting the generation of the spacing step variables when this layout setting is not set 🤔 |
@tellthemachines might you have time to dig in here based on your work with that inner blocks width setting? |
Thanks for reporting this @ndiego! I can confirm there's a missing bit of logic that should convert the preset values into CSS custom properties, and will have a fix up soon. |
Fixes a bug of invalid CSS value when applying block spacing to a block as reported in [WordPress/gutenberg#44435 Gutenberg issue 44435]. Adds logic to convert preset values (i.e. `$gap_value`) into valid CSS custom properties for the flow ('default') layout type. See the original fix in [#3324 Gutenberg PR 3324]. Also adds a test dataset that fails before the bugfix and passes after the bugix. Follow-up to [54274]. Props ndiego, isabel_brison, ramonopoly, andrewserong, hellofromTonya. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54311 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a bug of invalid CSS value when applying block spacing to a block as reported in [WordPress/gutenberg#44435 Gutenberg issue 44435]. Adds logic to convert preset values (i.e. `$gap_value`) into valid CSS custom properties for the flow ('default') layout type. See the original fix in [WordPress/wordpress-develop#3324 Gutenberg PR 3324]. Also adds a test dataset that fails before the bugfix and passes after the bugix. Follow-up to [54274]. Props ndiego, isabel_brison, ramonopoly, andrewserong, hellofromTonya. See #56467. Built from https://develop.svn.wordpress.org/trunk@54311 git-svn-id: http://core.svn.wordpress.org/trunk@53870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes a bug of invalid CSS value when applying block spacing to a block as reported in [WordPress/gutenberg#44435 Gutenberg issue 44435]. Adds logic to convert preset values (i.e. `$gap_value`) into valid CSS custom properties for the flow ('default') layout type. See the original fix in [WordPress/wordpress-develop#3324 Gutenberg PR 3324]. Also adds a test dataset that fails before the bugfix and passes after the bugix. Follow-up to [54274]. Props ndiego, isabel_brison, ramonopoly, andrewserong, hellofromTonya. See #56467. Built from https://develop.svn.wordpress.org/trunk@54311 git-svn-id: https://core.svn.wordpress.org/trunk@53870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Fixes a bug of invalid CSS value when applying block spacing to a block as reported in [WordPress/gutenberg#44435 Gutenberg issue 44435]. Adds logic to convert preset values (i.e. `$gap_value`) into valid CSS custom properties for the flow ('default') layout type. See the original fix in [WordPress#3324 Gutenberg PR 3324]. Also adds a test dataset that fails before the bugfix and passes after the bugix. Follow-up to [54274]. Props ndiego, isabel_brison, ramonopoly, andrewserong, hellofromTonya. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54311 602fd350-edb4-49c9-b593-d223f7449a82
Description
When applying Block Spacing to various blocks using the new spacing steps, often the variable is not generated correctly. Switching to manual spacing works as expected. This was tested using 6.1 and Gutenberg trunk. The same issue occurs without Gutenberg active.
Step-by-step reproduction instructions
Sample code for replicating (using TT3):
Screenshots, screen recording, code snippet
Editor View:
Frontend View:
Error:
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: